diff --git a/src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp b/src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp index 93e4091b48..8062a91481 100644 --- a/src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp +++ b/src/libxrpl/tx/transactors/escrow/EscrowCreate.cpp @@ -133,9 +133,8 @@ EscrowCreate::calculateBaseFee(ReadView const& view, STTx const& tx) bool EscrowCreate::checkExtraFeatures(PreflightContext const& ctx) { - return !( - (ctx.tx.isFieldPresent(sfFinishFunction) || ctx.tx.isFieldPresent(sfData)) && - !ctx.rules.enabled(featureSmartEscrow)); + return (!ctx.tx.isFieldPresent(sfFinishFunction) && !ctx.tx.isFieldPresent(sfData)) || + ctx.rules.enabled(featureSmartEscrow); } NotTEC diff --git a/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp b/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp index 63f19afd90..693729df4e 100644 --- a/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp +++ b/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -37,6 +38,7 @@ #include #include #include +#include #include #include #include @@ -167,7 +169,8 @@ EscrowFinish::calculateBaseFee(ReadView const& view, STTx const& tx) // The extra fee is the allowance in drops, rounded up to the nearest // whole drop. // Integer math rounds down by default, so we add 1 to round up. - uint64_t const allowanceFee = ((*allowance) * view.fees().gasPrice) / microDropsPerDrop + 1; + uint64_t const allowanceFee = + (((*allowance) * view.fees().gasPrice) / microDropsPerDrop) + 1; extraFee += allowanceFee; } return Transactor::calculateBaseFee(view, tx) + extraFee; diff --git a/src/test/app/EscrowSmart_test.cpp b/src/test/app/EscrowSmart_test.cpp index 05cca0545e..9fe7ef0538 100644 --- a/src/test/app/EscrowSmart_test.cpp +++ b/src/test/app/EscrowSmart_test.cpp @@ -5,7 +5,6 @@ #include #include #include -#include #include #include #include @@ -14,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -27,7 +27,9 @@ #include +#include #include +#include #include #include #include @@ -49,6 +51,8 @@ #include #include #include +#include +#include namespace xrpl::test { @@ -917,7 +921,7 @@ struct EscrowSmart_test : public beast::unit_test::Suite auto const bigAllowance = 996'433; uint64_t const partialFeeCalc = - (static_cast(bigAllowance) * 1'000'000) / microDropsPerDrop + 1; + ((static_cast(bigAllowance) * 1'000'000) / microDropsPerDrop) + 1; auto finishFee = env.current()->fees().base + partialFeeCalc; BEAST_EXPECT(finishFee.drops() > bigAllowance); diff --git a/src/test/app/wasm_fixtures/fixtures.cpp b/src/test/app/wasm_fixtures/fixtures.cpp index cbdbba749c..10aebf628b 100644 --- a/src/test/app/wasm_fixtures/fixtures.cpp +++ b/src/test/app/wasm_fixtures/fixtures.cpp @@ -2,7 +2,9 @@ #include +#include #include +#include namespace wasm_constants { @@ -15,10 +17,10 @@ appendU32Leb(std::vector& out, uint32_t value) { auto byte = static_cast(value & 0x7f); value >>= 7; - if (value) + if (value != 0u) byte |= 0x80; out.push_back(byte); - } while (value); + } while (value != 0u); } void