From 1c38bbdf45d5af2a1b3d5b23aa8afd727b23025b Mon Sep 17 00:00:00 2001
From: Ed Hennis <ed@ripple.com>
Date: Sat, 22 Nov 2025 21:33:30 -0500
Subject: [PATCH] Review feedback from @gregtatcam

- Remove unneeded proxy variables. Set the fields directly.
---
 src/xrpld/app/tx/detail/LoanManage.cpp | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/src/xrpld/app/tx/detail/LoanManage.cpp b/src/xrpld/app/tx/detail/LoanManage.cpp
index 4ba8808816..cf1d143c1b 100644
--- a/src/xrpld/app/tx/detail/LoanManage.cpp
+++ b/src/xrpld/app/tx/detail/LoanManage.cpp
@@ -135,13 +135,6 @@ LoanManage::defaultLoan(
     std::int32_t const loanScale = loanSle->at(sfLoanScale);
     auto brokerDebtTotalProxy = brokerSle->at(sfDebtTotal);
 
-    auto principalOutstandingProxy = loanSle->at(sfPrincipalOutstanding);
-    auto managementFeeOutstandingProxy =
-        loanSle->at(sfManagementFeeOutstanding);
-
-    auto totalValueOutstandingProxy = loanSle->at(sfTotalValueOutstanding);
-    auto paymentRemainingProxy = loanSle->at(sfPaymentRemaining);
-
     Number const totalDefaultAmount = owedToVault(loanSle);
 
     // Apply the First-Loss Capital to the Default Amount
@@ -267,10 +260,11 @@ LoanManage::defaultLoan(
 
     // Update the Loan object:
     loanSle->setFlag(lsfLoanDefault);
-    totalValueOutstandingProxy = 0;
-    paymentRemainingProxy = 0;
-    principalOutstandingProxy = 0;
-    managementFeeOutstandingProxy = 0;
+
+    loanSle->at(sfTotalValueOutstanding) = 0;
+    loanSle->at(sfPaymentRemaining) = 0;
+    loanSle->at(sfPrincipalOutstanding) = 0;
+    loanSle->at(sfManagementFeeOutstanding) = 0;
     // Zero out the next due date. Since it's default, it'll be removed from
     // the object.
     loanSle->at(sfNextPaymentDueDate) = 0;