From 1bffe264f0a8a5a57eeb3a79cc8ffa31335a847a Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Mon, 21 Sep 2026 12:52:13 +0100 Subject: [PATCH] fix(test): follow PerfLog's rpc hooks to string_view PerfLog takes the method name as a std::string_view, so SilentPerfLog's three rpc overrides stopped overriding anything and left the class abstract. --- src/test/core/JobQueue_test.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/test/core/JobQueue_test.cpp b/src/test/core/JobQueue_test.cpp index 47c0995cde..f208bbaff1 100644 --- a/src/test/core/JobQueue_test.cpp +++ b/src/test/core/JobQueue_test.cpp @@ -31,6 +31,7 @@ #include #include #include +#include #include #include @@ -243,15 +244,15 @@ public: class SilentPerfLog : public perf::PerfLog { void - rpcStart(std::string const&, std::uint64_t) override + rpcStart(std::string_view, std::uint64_t) override { } void - rpcFinish(std::string const&, std::uint64_t) override + rpcFinish(std::string_view, std::uint64_t) override { } void - rpcError(std::string const&, std::uint64_t) override + rpcError(std::string_view, std::uint64_t) override { } void