ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use 'magic numbers' for transaction types. Extra transaction constants.

Browse Source 
getFormat function.
This commit is contained in:
JoelKatz
2012-03-20 11:21:40 -07:00
parent 325ebc2312
commit 18ca0ebb21
2 changed files with 31 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/TransactionFormats.cpp
View File

@@ -3,7 +3,7 @@
TransactionFormat InnerTxnFormats[]= TransactionFormat InnerTxnFormats[]=
{ {
{ "MakePayment", 0, { { "MakePayment", ttMAKE_PAYMENT, {
{ "Flags", STI_UINT16, SOE_FLAGS, 0 }, { "Flags", STI_UINT16, SOE_FLAGS, 0 },
{ "Sequence", STI_UINT32, SOE_REQUIRED, 0 }, { "Sequence", STI_UINT32, SOE_REQUIRED, 0 },
{ "Destination", STI_ACCOUNT, SOE_REQUIRED, 0 }, { "Destination", STI_ACCOUNT, SOE_REQUIRED, 0 },
@@ -15,7 +15,7 @@ TransactionFormat InnerTxnFormats[]=
{ "Extensions", STI_TL, SOE_IFFLAG, 32768 }, { "Extensions", STI_TL, SOE_IFFLAG, 32768 },
{ NULL, STI_DONE, SOE_NEVER, -1 } } { NULL, STI_DONE, SOE_NEVER, -1 } }
}, },
{ "Invoice", 1, { { "Invoice", ttINVOICE, {
{ "Flags", STI_UINT16, SOE_FLAGS, 0 }, { "Flags", STI_UINT16, SOE_FLAGS, 0 },
{ "Sequence", STI_UINT32, SOE_REQUIRED, 0 }, { "Sequence", STI_UINT32, SOE_REQUIRED, 0 },
{ "Target", STI_ACCOUNT, SOE_REQUIRED, 0 }, { "Target", STI_ACCOUNT, SOE_REQUIRED, 0 },
@@ -28,7 +28,7 @@ TransactionFormat InnerTxnFormats[]=
{ "Extensions", STI_TL, SOE_IFFLAG, 32768 }, { "Extensions", STI_TL, SOE_IFFLAG, 32768 },
{ NULL, STI_DONE, SOE_NEVER, -1 } } { NULL, STI_DONE, SOE_NEVER, -1 } }
}, },
{ "Offer", 2, { { "Offer", ttEXCHANGE_OFFER, {
{ "Flags", STI_UINT16, SOE_FLAGS, 0 }, { "Flags", STI_UINT16, SOE_FLAGS, 0 },
{ "Sequence", STI_UINT32, SOE_REQUIRED, 0 }, { "Sequence", STI_UINT32, SOE_REQUIRED, 0 },
{ "AmountIn", STI_UINT64, SOE_REQUIRED, 0 }, { "AmountIn", STI_UINT64, SOE_REQUIRED, 0 },
@@ -42,5 +42,17 @@ TransactionFormat InnerTxnFormats[]=
{ "Identifier", STI_VL, SOE_IFFLAG, 128 }, { "Identifier", STI_VL, SOE_IFFLAG, 128 },
{ "Extensions", STI_TL, SOE_IFFLAG, 32768 }, { "Extensions", STI_TL, SOE_IFFLAG, 32768 },
{ NULL, STI_DONE, SOE_NEVER, -1 } } { NULL, STI_DONE, SOE_NEVER, -1 } }
} },
{ NULL, ttINVALID }
}; };
TransactionFormat* getFormat(TransactionType t)
{
TransactionFormat* f=InnerTxnFormats;
while(f->t_name!=NULL)
{
if(f->t_type==t) return f;
f++;
}
return NULL;
}

25
src/TransactionFormats.h
View File

@@ -5,20 +5,25 @@
#define STI_ACCOUNT STI_HASH160 #define STI_ACCOUNT STI_HASH160
struct TransactionFormat
{
const char *t_name;
int t_id;
SOElement elements[16];
};
extern TransactionFormat InnerTxnFormats[];
enum TransactionType enum TransactionType
{ {
ttINVALID=-1,
ttMAKE_PAYMENT=0, ttMAKE_PAYMENT=0,
ttNTX_INVOICE=1, ttINVOICE=1,
ttEXCHANGE_OFFER=2 ttEXCHANGE_OFFER=2
}; };
struct TransactionFormat
{
const char *t_name;
TransactionType t_type;
SOElement elements[16];
};
const int32 TransactionMagic=0x54583000;
const int TransactionMinLen=32;
const int TransactionMaxLen=1048576;
extern TransactionFormat InnerTxnFormats[];
extern TransactionFormat* getFormat(TransactionType t);
#endif #endif