From 180c905a8ac2c66d10d049de554c6f7f9e7daa62 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Thu, 11 Jun 2026 17:20:50 +0100 Subject: [PATCH] docs(telemetry): remove incorrect "rule 5" justification in Phase 4 task list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Three entries in Phase4_taskList.md annotated dotted attribute keys (`xrpl.consensus.round`, `round_id`, `ledger_id`) as "(kept — rule 5)". That is wrong: rule 5 keeps SPAN NAMES dotted, not attribute keys — the code emits the underscore form (consensus_round, consensus_round_id, consensus_ledger_id) per ConsensusSpanNames.h. Remove the false justification; the dotted form in this task list remains as the illustrative-readability form documented in the note at the top of the file. Co-Authored-By: Claude Opus 4.8 --- OpenTelemetryPlan/Phase4_taskList.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/OpenTelemetryPlan/Phase4_taskList.md b/OpenTelemetryPlan/Phase4_taskList.md index e7c1969d6a..9973331651 100644 --- a/OpenTelemetryPlan/Phase4_taskList.md +++ b/OpenTelemetryPlan/Phase4_taskList.md @@ -89,7 +89,7 @@ - In `Adaptor::propose()`: - Creates `consensus.proposal.send` span via `SpanGuard::span()` - - Sets `xrpl.consensus.round` attribute (kept — rule 5) + - Sets `xrpl.consensus.round` attribute - In `PeerImp::onMessage(TMProposeSet)`: - Creates `consensus.proposal.receive` span @@ -822,8 +822,8 @@ and OFF, and don't affect consensus timing. ```cpp // Round-level (on consensus.round) — ALL IMPLEMENTED -"xrpl.consensus.round_id" = int64 // Consensus round number (kept — rule 5) -"xrpl.consensus.ledger_id" = string // previousLedger.id() hash (kept — rule 5) +"xrpl.consensus.round_id" = int64 // Consensus round number +"xrpl.consensus.ledger_id" = string // previousLedger.id() hash "trace_strategy" = string // "deterministic" or "attribute" // Establish-level — IMPLEMENTED