ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix the memory leak in table index

Browse Source 
Summary:

BinarySearchIndex didn't use unique_ptr to guard the block object nor
delete it in destructor, leading to valgrind failure for "definite
memory leak".

Test Plan:
re-ran the failed valgrind test cases
This commit is contained in:
Kai Liu
2014-03-01 11:50:35 -08:00
parent ff151132b3
commit 16d4e45c12
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
table/block_based_table_reader.cc
View File

@@ -181,7 +181,7 @@ class BinarySearchIndexReader : public IndexReader {
: IndexReader(comparator), index_block_(index_block) { : IndexReader(comparator), index_block_(index_block) {
assert(index_block_ != nullptr); assert(index_block_ != nullptr);
} }
Block* index_block_; std::unique_ptr<Block> index_block_;
}; };
// TODO(kailiu) This class is only a stub for now. And the comment below is also // TODO(kailiu) This class is only a stub for now. And the comment below is also