refactor: Update to Boost 1.88 (#5570)

This updates Boost to 1.88, which is needed because Clio wants to move to 1.88 as that fixes several ASAN false positives around coroutine usage. In order for Clio to move to newer boost, libXRPL needs to move too. Hence the changes in this PR. A lot has changed between 1.83 and 1.88 so there are lots of changes in the diff, especially in regards to Boost.Asio and coroutines in particular.

src/libxrpl/net/HTTPClient.cpp

@@ -24,6 +24,7 @@
 #include <xrpl/net/HTTPClientSSLContext.h>
 
 #include <boost/asio.hpp>
+#include <boost/asio/ip/resolver_query_base.hpp>
 #include <boost/asio/ip/tcp.hpp>
 #include <boost/asio/ssl.hpp>
 #include <boost/regex.hpp>
@@ -55,16 +56,16 @@ class HTTPClientImp : public std::enable_shared_from_this<HTTPClientImp>,
 {
 public:
     HTTPClientImp(
-        boost::asio::io_service& io_service,
+        boost::asio::io_context& io_context,
         unsigned short const port,
         std::size_t maxResponseSize,
         beast::Journal& j)
-        : mSocket(io_service, httpClientSSLContext->context())
-        , mResolver(io_service)
+        : mSocket(io_context, httpClientSSLContext->context())
+        , mResolver(io_context)
         , mHeader(maxClientHeaderBytes)
         , mPort(port)
         , maxResponseSize_(maxResponseSize)
-        , mDeadline(io_service)
+        , mDeadline(io_context)
         , j_(j)
     {
     }
@@ -146,18 +147,21 @@ public:
     {
         JLOG(j_.trace()) << "Fetch: " << mDeqSites[0];
 
-        auto query = std::make_shared<boost::asio::ip::tcp::resolver::query>(
+        auto query = std::make_shared<Query>(
             mDeqSites[0],
             std::to_string(mPort),
             boost::asio::ip::resolver_query_base::numeric_service);
         mQuery = query;
 
-        mDeadline.expires_from_now(mTimeout, mShutdown);
-
-        JLOG(j_.trace()) << "expires_from_now: " << mShutdown.message();
-
-        if (!mShutdown)
+        try
         {
+            mDeadline.expires_after(mTimeout);
+        }
+        catch (boost::system::system_error const& e)
+        {
+            mShutdown = e.code();
+
+            JLOG(j_.trace()) << "expires_after: " << mShutdown.message();
             mDeadline.async_wait(std::bind(
                 &HTTPClientImp::handleDeadline,
                 shared_from_this(),
@@ -169,7 +173,9 @@ public:
             JLOG(j_.trace()) << "Resolving: " << mDeqSites[0];
 
             mResolver.async_resolve(
-                *mQuery,
+                mQuery->host,
+                mQuery->port,
+                mQuery->flags,
                 std::bind(
                     &HTTPClientImp::handleResolve,
                     shared_from_this(),
@@ -233,7 +239,7 @@ public:
     void
     handleResolve(
         boost::system::error_code const& ecResult,
-        boost::asio::ip::tcp::resolver::iterator itrEndpoint)
+        boost::asio::ip::tcp::resolver::results_type result)
     {
         if (!mShutdown)
         {
@@ -255,7 +261,7 @@ public:
 
             boost::asio::async_connect(
                 mSocket.lowest_layer(),
-                itrEndpoint,
+                result,
                 std::bind(
                     &HTTPClientImp::handleConnect,
                     shared_from_this(),
@@ -475,13 +481,15 @@ public:
         std::string const& strData = "")
     {
         boost::system::error_code ecCancel;
-
-        (void)mDeadline.cancel(ecCancel);
-
-        if (ecCancel)
+        try
         {
-            JLOG(j_.trace()) << "invokeComplete: Deadline cancel error: "
-                             << ecCancel.message();
+            mDeadline.cancel();
+        }
+        catch (boost::system::system_error const& e)
+        {
+            JLOG(j_.trace())
+                << "invokeComplete: Deadline cancel error: " << e.what();
+            ecCancel = e.code();
         }
 
         JLOG(j_.debug()) << "invokeComplete: Deadline popping: "
@@ -515,7 +523,15 @@ private:
     bool mSSL;
     AutoSocket mSocket;
     boost::asio::ip::tcp::resolver mResolver;
-    std::shared_ptr<boost::asio::ip::tcp::resolver::query> mQuery;
+
+    struct Query
+    {
+        std::string host;
+        std::string port;
+        boost::asio::ip::resolver_query_base::flags flags;
+    };
+    std::shared_ptr<Query> mQuery;
+
     boost::asio::streambuf mRequest;
     boost::asio::streambuf mHeader;
     boost::asio::streambuf mResponse;
@@ -546,7 +562,7 @@ private:
 void
 HTTPClient::get(
     bool bSSL,
-    boost::asio::io_service& io_service,
+    boost::asio::io_context& io_context,
     std::deque<std::string> deqSites,
     unsigned short const port,
     std::string const& strPath,
@@ -559,14 +575,14 @@ HTTPClient::get(
     beast::Journal& j)
 {
     auto client =
-        std::make_shared<HTTPClientImp>(io_service, port, responseMax, j);
+        std::make_shared<HTTPClientImp>(io_context, port, responseMax, j);
     client->get(bSSL, deqSites, strPath, timeout, complete);
 }
 
 void
 HTTPClient::get(
     bool bSSL,
-    boost::asio::io_service& io_service,
+    boost::asio::io_context& io_context,
     std::string strSite,
     unsigned short const port,
     std::string const& strPath,
@@ -581,14 +597,14 @@ HTTPClient::get(
     std::deque<std::string> deqSites(1, strSite);
 
     auto client =
-        std::make_shared<HTTPClientImp>(io_service, port, responseMax, j);
+        std::make_shared<HTTPClientImp>(io_context, port, responseMax, j);
     client->get(bSSL, deqSites, strPath, timeout, complete);
 }
 
 void
 HTTPClient::request(
     bool bSSL,
-    boost::asio::io_service& io_service,
+    boost::asio::io_context& io_context,
     std::string strSite,
     unsigned short const port,
     std::function<void(boost::asio::streambuf& sb, std::string const& strHost)>
@@ -604,7 +620,7 @@ HTTPClient::request(
     std::deque<std::string> deqSites(1, strSite);
 
     auto client =
-        std::make_shared<HTTPClientImp>(io_service, port, responseMax, j);
+        std::make_shared<HTTPClientImp>(io_context, port, responseMax, j);
     client->request(bSSL, deqSites, setRequest, timeout, complete);
 }