From 498bc3ee961c60e2b54f46bfadd2c9dca075f731 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Fri, 26 Jun 2026 17:37:37 +0100 Subject: [PATCH] fix(telemetry): satisfy clang-tidy const-correctness and redundant-parens CI enabled more clang-tidy checks via the upstream merge: - DiscardScope discardScope -> const (misc-const-correctness) - drop the (::max)() Windows macro-guard parens; NOMINMAX is defined project-wide so the bare form is correct (readability-redundant-parentheses) Co-Authored-By: Claude Opus 4.8 --- src/libxrpl/telemetry/SpanGuard.cpp | 2 +- src/libxrpl/telemetry/Telemetry.cpp | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/libxrpl/telemetry/SpanGuard.cpp b/src/libxrpl/telemetry/SpanGuard.cpp index 193c8de2f1..26c14c20be 100644 --- a/src/libxrpl/telemetry/SpanGuard.cpp +++ b/src/libxrpl/telemetry/SpanGuard.cpp @@ -361,7 +361,7 @@ SpanGuard::discard() // flag leak-proof if a later phase can hand back a non-recording // span (e.g. honoring a non-sampled remote parent during // propagation), so it can never spill onto the next span. - DiscardScope discardScope; + DiscardScope const discardScope; impl_->span->End(); } impl_->span = nullptr; // prevent ~Impl from calling End() again diff --git a/src/libxrpl/telemetry/Telemetry.cpp b/src/libxrpl/telemetry/Telemetry.cpp index 23643e9a7e..b23ac9e83b 100644 --- a/src/libxrpl/telemetry/Telemetry.cpp +++ b/src/libxrpl/telemetry/Telemetry.cpp @@ -131,14 +131,13 @@ public: bool ForceFlush( - std::chrono::microseconds timeout = (std::chrono::microseconds::max)()) noexcept override + std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override { return delegate_->ForceFlush(timeout); } bool - Shutdown( - std::chrono::microseconds timeout = (std::chrono::microseconds::max)()) noexcept override + Shutdown(std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override { return delegate_->Shutdown(timeout); }