ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-05 08:48:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Server race conditions:

Browse Source 
Class io_list manages children that perform asynchronous
I/O operations. The treatment of close and destruction is
refactored to fix race conditions during exit.
This commit is contained in:
Vinnie Falco
2016-02-08 10:19:25 -05:00
parent 137dd351b8
commit 0f7dbc7bc0
17 changed files with 434 additions and 400 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/ripple/server/impl/PlainHTTPPeer.h
View File

@@ -37,8 +37,9 @@ private:
public:
template <class ConstBufferSequence>
PlainHTTPPeer (Door& door, beast::Journal journal, endpoint_type endpoint,
ConstBufferSequence const& buffers, socket_type&& socket);
PlainHTTPPeer (Port const& port, Handler& handler,
beast::Journal journal, endpoint_type remote_address,
ConstBufferSequence const& buffers, socket_type&& socket);
void
run();
@@ -54,10 +55,10 @@ private:
//------------------------------------------------------------------------------
template <class ConstBufferSequence>
PlainHTTPPeer::PlainHTTPPeer (Door& door, beast::Journal journal,
endpoint_type remote_address, ConstBufferSequence const& buffers,
socket_type&& socket)
: BaseHTTPPeer (door, socket.get_io_service(), journal, remote_address, buffers)
PlainHTTPPeer::PlainHTTPPeer (Port const& port, Handler& handler,
beast::Journal journal, endpoint_type remote_address,
ConstBufferSequence const& buffers, socket_type&& socket)
: BaseHTTPPeer(port, handler, socket.get_io_service(), journal, remote_address, buffers)
, stream_(std::move(socket))
{
}
@@ -65,7 +66,7 @@ PlainHTTPPeer::PlainHTTPPeer (Door& door, beast::Journal journal,
void
PlainHTTPPeer::run ()
{
door_.server().handler()->onAccept (session());
handler_.onAccept (session());
if (! stream_.is_open())
return;
@@ -77,7 +78,7 @@ void
PlainHTTPPeer::do_request()
{
++request_count_;
auto const what = door_.server().handler()->onHandoff (session(),
auto const what = handler_.onHandoff (session(),
std::move(stream_), std::move(message_), remote_address_);
if (what.moved)
return;
@@ -98,7 +99,7 @@ PlainHTTPPeer::do_request()
if (ec)
return fail (ec, "request");
// legacy
door_.server().handler()->onRequest (session());
handler_.onRequest (session());
}
void