ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 16:56:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Enable more clang-tidy readability checks (#6595)

Browse Source 
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com>
This commit is contained in:
Alex Kremer
2026-03-24 15:42:12 +00:00
committed by GitHub
parent 8b986e4ab0
commit 0eedefbf45
248 changed files with 948 additions and 935 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/test/app/TxQ_test.cpp
View File

@@ -24,7 +24,7 @@ class TxQPosNegFlows_test : public beast::unit_test::suite
static constexpr FeeLevel64 baseFeeLevel{256};
static constexpr FeeLevel64 minEscalationFeeLevel = baseFeeLevel * 500;
void
static void
fillQueue(jtx::Env& env, jtx::Account const& account)
{
auto metrics = env.app().getTxQ().getMetrics(*env.current());
@@ -32,7 +32,7 @@ class TxQPosNegFlows_test : public beast::unit_test::suite
env(noop(account));
}
auto
static auto
openLedgerCost(jtx::Env& env)
{
using namespace jtx;
@@ -52,7 +52,7 @@ class TxQPosNegFlows_test : public beast::unit_test::suite
// Get a fee level of a transaction made by an account
// This fee level is used to ensure we can place transaction into TxQ
auto
static auto
txFeeLevelByAccount(jtx::Env& env, jtx::Account const& account)
{
using namespace jtx;
@@ -65,7 +65,7 @@ class TxQPosNegFlows_test : public beast::unit_test::suite
// Calculating expected median fee level based on known fee levels of median
// transaction levels.
auto
static auto
calcMedFeeLevel(FeeLevel64 const feeLevel1, FeeLevel64 const feeLevel2)
{
FeeLevel64 const expectedMedFeeLevel = (feeLevel1 + feeLevel2 + FeeLevel64{1}) / 2;
@@ -73,7 +73,7 @@ class TxQPosNegFlows_test : public beast::unit_test::suite
return std::max(expectedMedFeeLevel, minEscalationFeeLevel).fee();
}
auto
static auto
calcMedFeeLevel(FeeLevel64 const feeLevel)
{
return calcMedFeeLevel(feeLevel, feeLevel);
@@ -551,16 +551,16 @@ public:
// The lowest fee ticket is baseFee * 2.1, trying to replace it
env(noop(alice),
ticket::use(tkt1 + 18),
fee(baseFee * 2.1 * 1.25 - 1),
fee((baseFee * 2.1 * 1.25) - 1),
ter(telCAN_NOT_QUEUE_FEE));
env(noop(alice), ticket::use(tkt1 + 18), fee(baseFee * 2.1 * 1.25 + 1), queued);
env(noop(alice), ticket::use(tkt1 + 18), fee((baseFee * 2.1 * 1.25) + 1), queued);
// New lowest fee ticket is baseFee * 2.2
env(noop(alice),
ticket::use(tkt250 - 4),
fee(baseFee * 2.2 * 1.25 - 1),
fee((baseFee * 2.2 * 1.25) - 1),
ter(telCAN_NOT_QUEUE_FEE));
env(noop(alice), ticket::use(tkt250 - 4), fee(baseFee * 2.2 * 1.25 + 1), queued);
env(noop(alice), ticket::use(tkt250 - 4), fee((baseFee * 2.2 * 1.25) + 1), queued);
env.close();
env.require(owners(alice, 227), tickets(alice, 227));
@@ -858,7 +858,7 @@ public:
++seqCarol;
}
// clang-format off
checkMetrics(*this, env, 6, 6, 4, 3, baseFeeLevel.fee() * aliceFeeMultiplier + 1);
checkMetrics(*this, env, 6, 6, 4, 3, (baseFeeLevel.fee() * aliceFeeMultiplier) + 1);
// clang-format on
// Carol submits high enough to beat Bob's average fee which kicks
@@ -2632,7 +2632,7 @@ public:
// Start by procuring tickets for alice to use to keep her queue full
// without affecting the sequence gap that will appear later.
env(ticket::create(alice, 11), seq(aliceSeq + 0), fee(baseFee * 20 + 1), ter(terQUEUED));
env(ticket::create(alice, 11), seq(aliceSeq + 0), fee((baseFee * 20) + 1), ter(terQUEUED));
env(noop(alice), seq(aliceSeq + 11), last_ledger_seq(11), ter(terQUEUED));
env(noop(alice), seq(aliceSeq + 12), last_ledger_seq(11), ter(terQUEUED));
env(noop(alice), seq(aliceSeq + 13), last_ledger_seq(11), ter(terQUEUED));
@@ -4083,7 +4083,7 @@ public:
// Use fees to guarantee order
int txFee{static_cast<int>(baseFee * 9)};
auto prepareFee = [&](uint64_t multiplier) {
return fee(txFee - multiplier * baseFee / 10);
return fee(txFee - (multiplier * baseFee / 10));
};
uint64_t multiplier = 0;