ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-25 16:10:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: nomenclature and additional testing

Browse Source
This commit is contained in:
Denis Angell
2026-06-23 17:51:28 -04:00
parent bf5f8f2c10
commit 0db6113a0e
2 changed files with 163 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/libxrpl/protocol/STTx.cpp
View File

@@ -291,11 +291,14 @@ STTx::checkBatchSign(Rules const& rules) const
try
{
XRPL_ASSERT(getTxnType() == ttBATCH, "STTx::checkBatchSign : not a batch transaction");
// LCOV_EXCL_START - defensive: the assert above guarantees ttBATCH;
// this guard only protects release builds where asserts are no-ops.
if (getTxnType() != ttBATCH)
{
JLOG(debugLog().fatal()) << "not a batch transaction";
return std::unexpected("Not a batch transaction.");
}
// LCOV_EXCL_STOP
if (!isFieldPresent(sfBatchSigners))
return std::unexpected("Missing BatchSigners field.");
STArray const& signers{getFieldArray(sfBatchSigners)};
@@ -569,6 +572,9 @@ STTx::checkMultiSign(Rules const& rules, STObject const& sigObject) const
void
STTx::buildBatchTxnIds()
{
// Precondition: applyTemplate() must have run first, so the fields
// (including sfRawTransactions) are canonical before the inner txns
// are hashed. The constructors call this immediately after applyTemplate().
if (getTxnType() != ttBATCH || !isFieldPresent(sfRawTransactions))
return;
@@ -728,13 +734,13 @@ invalidMPTAmountInTx(STObject const& tx)
}
static bool
isRawTransactionOkay(STObject const& st, std::string& reason)
isBatchRawTransactionOkay(STObject const& st, std::string& reason)
{
if (!st.isFieldPresent(sfRawTransactions))
return true;
if (st.isFieldPresent(sfBatchSigners) &&
st.getFieldArray(sfBatchSigners).size() > kMaxBatchTxCount)
st.getFieldArray(sfBatchSigners).size() > kMaxBatchSigners)
{
reason = "Batch Signers array exceeds max entries.";
return false;
@@ -795,7 +801,7 @@ passesLocalChecks(STObject const& st, std::string& reason)
return false;
}
if (!isRawTransactionOkay(st, reason))
if (!isBatchRawTransactionOkay(st, reason))
return false;
return true;