From 190b9470a4ac88544704c9797e57625e8030653e Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Fri, 26 Jun 2026 16:31:06 +0100 Subject: [PATCH] =?UTF-8?q?docs(telemetry):=20fix=20xrpl.network.type=20va?= =?UTF-8?q?lue=20(standalone=20=E2=86=92=20unknown)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The network-type label is derived from [network_id] in TelemetryConfig.cpp; unmapped/unset IDs fall through to "unknown", not "standalone". Align the design-doc resource-attribute table with the code and cfg example. Co-Authored-By: Claude Opus 4.8 --- OpenTelemetryPlan/02-design-decisions.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/OpenTelemetryPlan/02-design-decisions.md b/OpenTelemetryPlan/02-design-decisions.md index 64d1da123b..a30df9e755 100644 --- a/OpenTelemetryPlan/02-design-decisions.md +++ b/OpenTelemetryPlan/02-design-decisions.md @@ -215,15 +215,15 @@ Resource attributes identify the process and are set once at startup. They use the standard OpenTelemetry semantic conventions plus custom dotted `xrpl.*` keys (the dotted form is reserved for resource scope per ยง2.3.3). -| Key | Type / value | Description | -| --------------------- | ---------------------------------------------------------- | ------------------------------ | -| `service.name` | `"xrpld"` | Standard `SERVICE_NAME` | -| `service.version` | `BuildInfo::getVersionString()` | Standard `SERVICE_VERSION` | -| `service.instance.id` | node public key (base58) | Standard `SERVICE_INSTANCE_ID` | -| `xrpl.network.id` | network id (e.g. 0 for mainnet) | Network identifier | -| `xrpl.network.type` | `"mainnet"` \| `"testnet"` \| `"devnet"` \| `"standalone"` | Network kind | -| `xrpl.node.type` | `"validator"` \| `"stock"` \| `"reporting"` | Node role | -| `xrpl.node.cluster` | cluster name | Cluster name, if clustered | +| Key | Type / value | Description | +| --------------------- | ------------------------------------------------------- | ------------------------------ | +| `service.name` | `"xrpld"` | Standard `SERVICE_NAME` | +| `service.version` | `BuildInfo::getVersionString()` | Standard `SERVICE_VERSION` | +| `service.instance.id` | node public key (base58) | Standard `SERVICE_INSTANCE_ID` | +| `xrpl.network.id` | network id (e.g. 0 for mainnet) | Network identifier | +| `xrpl.network.type` | `"mainnet"` \| `"testnet"` \| `"devnet"` \| `"unknown"` | Network kind | +| `xrpl.node.type` | `"validator"` \| `"stock"` \| `"reporting"` | Node role | +| `xrpl.node.cluster` | cluster name | Cluster name, if clustered | ### 2.4.2 Span Attributes by Category