From 07bc6d2ce72fb8f9327db74694930840d00b75bd Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Fri, 24 Jul 2026 15:32:41 +0100
Subject: [PATCH] refactor(telemetry): name trace_id/span_id literals and hex
 widths in Log

Replace the raw "trace_id="/" span_id=" prefix literals and the bare 32/16
hex-width magic numbers in the log trace-context injection with named
constexpr constants (kTraceIdPrefix, kSpanIdPrefix, kTraceIdHexLen,
kSpanIdHexLen), documenting that the widths are the W3C 16-byte trace_id /
8-byte span_id rendered as lowercase hex. No behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 src/libxrpl/basics/Log.cpp | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/src/libxrpl/basics/Log.cpp b/src/libxrpl/basics/Log.cpp
index 7111bc5f34..46a3829e78 100644
--- a/src/libxrpl/basics/Log.cpp
+++ b/src/libxrpl/basics/Log.cpp
@@ -17,6 +17,7 @@
 #endif  // XRPL_ENABLE_TELEMETRY
 
 #include <chrono>
+#include <cstddef>
 #include <cstring>
 #include <fstream>
 #include <functional>
@@ -315,13 +316,21 @@ Logs::format(
             auto spanCtx = span->GetContext();
             if (spanCtx.IsValid())
             {
-                char traceId[32], spanId[16];
-                spanCtx.trace_id().ToLowerBase16(opentelemetry::nostd::span<char, 32>{traceId});
-                spanCtx.span_id().ToLowerBase16(opentelemetry::nostd::span<char, 16>{spanId});
-                output += "trace_id=";
-                output.append(traceId, 32);
-                output += " span_id=";
-                output.append(spanId, 16);
+                // Hex widths of a W3C trace context: 16-byte trace_id and
+                // 8-byte span_id render to 32 and 16 lowercase hex chars.
+                constexpr std::size_t kTraceIdHexLen = 32;
+                constexpr std::size_t kSpanIdHexLen = 16;
+                constexpr auto kTraceIdPrefix = "trace_id=";
+                constexpr auto kSpanIdPrefix = " span_id=";
+                char traceId[kTraceIdHexLen], spanId[kSpanIdHexLen];
+                spanCtx.trace_id().ToLowerBase16(
+                    opentelemetry::nostd::span<char, kTraceIdHexLen>{traceId});
+                spanCtx.span_id().ToLowerBase16(
+                    opentelemetry::nostd::span<char, kSpanIdHexLen>{spanId});
+                output += kTraceIdPrefix;
+                output.append(traceId, kTraceIdHexLen);
+                output += kSpanIdPrefix;
+                output.append(spanId, kSpanIdHexLen);
                 output += ' ';
             }
         }