From 0bb9716784ab24cec55e0849b8e0f1d54050f7cc Mon Sep 17 00:00:00 2001
From: Ed Hennis <ed@ripple.com>
Date: Thu, 6 Aug 2026 15:22:01 -0400
Subject: [PATCH] clang-tidy fixes: includes and explicit struct field names

---
 include/xrpl/nodestore/DatabaseRotating.h | 1 +
 src/xrpld/app/misc/SHAMapStoreImp.h       | 1 +
 src/xrpld/overlay/Message.h               | 1 -
 src/xrpld/overlay/detail/OverlayImpl.cpp  | 5 ++++-
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/include/xrpl/nodestore/DatabaseRotating.h b/include/xrpl/nodestore/DatabaseRotating.h
index 4c79d67672..00defe1ef3 100644
--- a/include/xrpl/nodestore/DatabaseRotating.h
+++ b/include/xrpl/nodestore/DatabaseRotating.h
@@ -6,6 +6,7 @@
 #include <xrpl/nodestore/Scheduler.h>
 #include <xrpl/protocol/Protocol.h>
 
+#include <cstdint>
 #include <functional>
 #include <memory>
 #include <string>
diff --git a/src/xrpld/app/misc/SHAMapStoreImp.h b/src/xrpld/app/misc/SHAMapStoreImp.h
index 851b5e5266..a3c181bea5 100644
--- a/src/xrpld/app/misc/SHAMapStoreImp.h
+++ b/src/xrpld/app/misc/SHAMapStoreImp.h
@@ -10,6 +10,7 @@
 #include <xrpl/nodestore/Backend.h>
 #include <xrpl/nodestore/Database.h>
 #include <xrpl/nodestore/DatabaseRotating.h>
+#include <xrpl/nodestore/NodeObject.h>
 #include <xrpl/nodestore/Scheduler.h>
 #include <xrpl/protocol/Protocol.h>
 #include <xrpl/rdb/DatabaseCon.h>
diff --git a/src/xrpld/overlay/Message.h b/src/xrpld/overlay/Message.h
index c72afda390..268aa3a332 100644
--- a/src/xrpld/overlay/Message.h
+++ b/src/xrpld/overlay/Message.h
@@ -4,7 +4,6 @@
 
 #include <xrpl/basics/ByteUtilities.h>
 #include <xrpl/protocol/PublicKey.h>
-#include <xrpl/protocol/messages.h>
 #include <xrpl/server/Manifest.h>
 
 #include <google/protobuf/message.h>
diff --git a/src/xrpld/overlay/detail/OverlayImpl.cpp b/src/xrpld/overlay/detail/OverlayImpl.cpp
index c345bca227..28231759bb 100644
--- a/src/xrpld/overlay/detail/OverlayImpl.cpp
+++ b/src/xrpld/overlay/detail/OverlayImpl.cpp
@@ -1279,7 +1279,10 @@ OverlayImpl::getManifestsMessage()
         app_.getValidatorManifests().forEachManifest(
             [&cached](std::size_t s) { cached.reserve(s); },
             [&cached](Manifest const& manifest) {
-                cached.push_back({manifest.masterKey, manifest.serialized, manifest.hash()});
+                cached.push_back(
+                    {.masterKey = manifest.masterKey,
+                     .serialized = manifest.serialized,
+                     .hash = manifest.hash()});
             });
 
         // Phase 2: no cache lock held, so trust checks are safe. Include every