From 0b8260725b37c0e64c2d520e63f66062b59de152 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Tue, 11 Aug 2026 13:46:08 -0400 Subject: [PATCH] fix: keep amendment default member initializer, silence clang-tidy --- include/xrpl/protocol/TxSettings.h | 8 +++++++- include/xrpl/protocol/detail/transactions.macro | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/xrpl/protocol/TxSettings.h b/include/xrpl/protocol/TxSettings.h index 142a4b3b25..94852afc90 100644 --- a/include/xrpl/protocol/TxSettings.h +++ b/include/xrpl/protocol/TxSettings.h @@ -71,7 +71,13 @@ struct TxSettings /** * The amendment gating this transaction, or uint256{} if always available. */ - uint256 amendment; + // The `{}` looks redundant, because BaseUInt's default constructor already + // zeroes the value. It is not: without a default member initializer here, + // every partial designated initializer in transactions.macro trips the + // missing-designated-field-initializers warning, which the build treats as + // an error. + // NOLINTNEXTLINE(readability-redundant-member-init) + uint256 amendment{}; /** * Operations this transaction is permitted to perform. diff --git a/include/xrpl/protocol/detail/transactions.macro b/include/xrpl/protocol/detail/transactions.macro index 03c31a0131..8ab54dc420 100644 --- a/include/xrpl/protocol/detail/transactions.macro +++ b/include/xrpl/protocol/detail/transactions.macro @@ -21,7 +21,7 @@ * struct TxSettings * { * Delegation delegable = Delegable; - * uint256 amendment; + * uint256 amendment{}; * Privilege privileges = NoPriv; * }; *