ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-27 14:35:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disallow invalid flags on OfferCreate transactions.

Browse Source
This commit is contained in:
Arthur Britto
2012-11-30 17:12:51 -08:00
parent 45841edb7d
commit 07a3eafd8a
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/cpp/ripple/OfferCreateTransactor.cpp
View File

@@ -244,8 +244,8 @@ TER OfferCreateTransactor::takeOffers(
TER OfferCreateTransactor::doApply() TER OfferCreateTransactor::doApply()
{ {
Log(lsWARNING) << "doOfferCreate> " << mTxn.getJson(0); Log(lsWARNING) << "doOfferCreate> " << mTxn.getJson(0);
const uint32 txFlags = mTxn.getFlags(); const uint32 uTxFlags = mTxn.getFlags();
const bool bPassive = isSetBit(txFlags, tfPassive); const bool bPassive = isSetBit(uTxFlags, tfPassive);
STAmount saTakerPays = mTxn.getFieldAmount(sfTakerPays); STAmount saTakerPays = mTxn.getFieldAmount(sfTakerPays);
STAmount saTakerGets = mTxn.getFieldAmount(sfTakerGets); STAmount saTakerGets = mTxn.getFieldAmount(sfTakerGets);
@@ -273,7 +273,13 @@ TER OfferCreateTransactor::doApply()
uint64 uOwnerNode; uint64 uOwnerNode;
uint64 uBookNode; uint64 uBookNode;
if (bHaveExpiration && !uExpiration) if (uTxFlags & tfOfferCreateMask)
{
Log(lsINFO) << "doOfferCreate: Malformed transaction: Invalid flags set.";
return temINVALID_FLAG;
}
else if (bHaveExpiration && !uExpiration)
{ {
Log(lsWARNING) << "doOfferCreate: Malformed offer: bad expiration"; Log(lsWARNING) << "doOfferCreate: Malformed offer: bad expiration";

1
src/cpp/ripple/TransactionFormats.h
View File

@@ -56,6 +56,7 @@ const int TransactionMaxLen = 1048576;
// OfferCreate flags: // OfferCreate flags:
const uint32 tfPassive = 0x00010000; const uint32 tfPassive = 0x00010000;
const uint32 tfOfferCreateMask = ~(tfPassive);
// Payment flags: // Payment flags:
const uint32 tfCreateAccount = 0x00010000; const uint32 tfCreateAccount = 0x00010000;