Review feedback

This commit is contained in:
Bart
2025-11-24 17:19:56 -05:00
parent 52059e7158
commit 078c1639ec
2 changed files with 6 additions and 6 deletions

View File

@@ -93,8 +93,7 @@ unfamiliar with Conan, then please read [this crash course](./docs/build/conan.m
To achieve reproducible dependencies, we use a [Conan lockfile](https://docs.conan.io/2/tutorial/versioning/lockfiles.html), To achieve reproducible dependencies, we use a [Conan lockfile](https://docs.conan.io/2/tutorial/versioning/lockfiles.html),
which has to be updated every time dependencies change. which has to be updated every time dependencies change.
Please see the instructions [here](conan/lockfile/README.md) on how to Please see the [instructions on how to regenerate the lockfile](conan/lockfile/README.md).
regenerate the lockfile.
#### Default profile #### Default profile

View File

@@ -1,4 +1,4 @@
## Conan lockfile # Conan lockfile
To achieve reproducible dependencies, we use a [Conan lockfile](https://docs.conan.io/2/tutorial/versioning/lockfiles.html). To achieve reproducible dependencies, we use a [Conan lockfile](https://docs.conan.io/2/tutorial/versioning/lockfiles.html).
@@ -9,13 +9,14 @@ need to specify it.
You have to update this file every time you add a new dependency or change a You have to update this file every time you add a new dependency or change a
revision or version of an existing dependency. revision or version of an existing dependency.
### Updating the lockfile ## Updating the lockfile
To update a new lockfile, run the following commands from the repository root: To update a lockfile, run the following commands from the repository root:
```bash ```bash
# Ensure that the xrplf remote is the first to be consulted, so any recipes we # Ensure that the xrplf remote is the first to be consulted, so any recipes we
# patched are used. # patched are used. We also add it there to not created huge diff when the
# official Conan Center Index is updated.
conan remote add --force --index 0 xrplf https://conan.ripplex.io conan remote add --force --index 0 xrplf https://conan.ripplex.io
# Remove all local packages to prevent the local cache from influencing the # Remove all local packages to prevent the local cache from influencing the