From 06219f11517e802d625efed49a1becae24ccbe00 Mon Sep 17 00:00:00 2001 From: seelabs Date: Fri, 23 Aug 2019 10:44:41 -0700 Subject: [PATCH] Disable shadow warning: Different compilers and handling the shadow warning differently. In particular, some are warning about types being shadowed by variables. Until these can be resolved the shadow warning is being disabled. Note: the shadow warning was originally enabled to help with the structured bindings patch. As that is now complete, it's less important to keep this warning. --- CMakeLists.txt | 6 ------ 1 file changed, 6 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 6117e1bc5e..9d387039c1 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -547,12 +547,6 @@ if (MSVC) else () # HACK : because these need to come first, before any warning demotion string (APPEND CMAKE_CXX_FLAGS " -Wall -Wdeprecated") - if (is_clang OR (is_gcc AND NOT unity)) - # gcc flags many more instances with `-Wshadow` than clang. Many incouous - # shadowings are flagged in unity mode. Only turn on gcc warnings in nonunity - # builds - string (APPEND CMAKE_CXX_FLAGS " -Wshadow") - endif() # not MSVC target_compile_options (common INTERFACE