ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-05 08:48:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add book_offers RPC tests (RIPD-1283):

Browse Source 
Migrate orderbook-test.js to cpp tests. Provide
coverage for error conditions in book_offers
RPC method.
This commit is contained in:
Mike Ellery
2016-09-22 16:08:52 -07:00
committed by Vinnie Falco
parent bb0b97f46b
commit 05e7373086
6 changed files with 568 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/ripple/app/misc/NetworkOPs.cpp
View File

@@ -277,9 +277,9 @@ public:
// Book functions.
//
void getBookPage (bool bUnlimited, std::shared_ptr<ReadView const>& lpLedger,
void getBookPage (std::shared_ptr<ReadView const>& lpLedger,
Book const&, AccountID const& uTakerID, const bool bProof,
const unsigned int iLimit,
unsigned int iLimit,
Json::Value const& jvMarker, Json::Value& jvResult)
override;
@@ -2832,14 +2832,12 @@ InfoSub::pointer NetworkOPsImp::addRpcSub (
// NIKB FIXME this should be looked at. There's no reason why this shouldn't
// work, but it demonstrated poor performance.
//
// FIXME : support iLimit.
void NetworkOPsImp::getBookPage (
bool bUnlimited,
std::shared_ptr<ReadView const>& lpLedger,
Book const& book,
AccountID const& uTakerID,
bool const bProof,
const unsigned int iLimit,
unsigned int iLimit,
Json::Value const& jvMarker,
Json::Value& jvResult)
{ // CAUTION: This is the old get book page logic
@@ -2876,11 +2874,7 @@ void NetworkOPsImp::getBookPage (
auto const rate = transferRate(view, book.out.account);
auto viewJ = app_.journal ("View");
unsigned int left (iLimit == 0 ? 300 : iLimit);
if (! bUnlimited && left > 300)
left = 300;
while (!bDone && left-- > 0)
while (! bDone && iLimit-- > 0)
{
if (bDirectAdvance)
{
@@ -3048,14 +3042,12 @@ void NetworkOPsImp::getBookPage (
// This is the new code that uses the book iterators
// It has temporarily been disabled
// FIXME : support iLimit.
void NetworkOPsImp::getBookPage (
bool bUnlimited,
std::shared_ptr<ReadView const> lpLedger,
Book const& book,
AccountID const& uTakerID,
bool const bProof,
const unsigned int iLimit,
unsigned int iLimit,
Json::Value const& jvMarker,
Json::Value& jvResult)
{
@@ -3071,11 +3063,7 @@ void NetworkOPsImp::getBookPage (
const bool bGlobalFreeze = lesActive.isGlobalFrozen (book.out.account) ||
lesActive.isGlobalFrozen (book.in.account);
unsigned int left (iLimit == 0 ? 300 : iLimit);
if (! bUnlimited && left > 300)
left = 300;
while (left-- > 0 && obIterator.nextOffer ())
while (iLimit-- > 0 && obIterator.nextOffer ())
{
SLE::pointer sleOffer = obIterator.getCurrentOffer();