From 47294b5ae8411f161ea66c4573e22ea7ac141009 Mon Sep 17 00:00:00 2001 From: Vito <5780819+Tapanito@users.noreply.github.com> Date: Thu, 1 Oct 2026 17:01:30 +0200 Subject: [PATCH 1/4] style: Fix clang-tidy findings in FixedPrecision headers --- src/libxrpl/tx/invariants/VaultInvariant.cpp | 4 ++++ src/test/app/vault/VaultFixedPrecisionBase.h | 14 -------------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/src/libxrpl/tx/invariants/VaultInvariant.cpp b/src/libxrpl/tx/invariants/VaultInvariant.cpp index b2eaa8b837..9d334f072e 100644 --- a/src/libxrpl/tx/invariants/VaultInvariant.cpp +++ b/src/libxrpl/tx/invariants/VaultInvariant.cpp @@ -456,10 +456,14 @@ ValidVault::checkTotalsAddUp( // deltas, not the values rounded to the posterior AssetsTotal scale. bool const availableAddsUp = [&] { if (afterVault.version == VaultVersion::FixedPrecision) + { return (afterVault.assetsAvailable - beforeVault.assetsAvailable) == exactVaultDelta; + } if (fix340Enabled) + { return agreesWithinOneUnit( assetAvailableDelta, roundedVaultDelta, vaultAsset, minScale); + } return assetAvailableDelta == roundedVaultDelta; }(); if (!availableAddsUp) diff --git a/src/test/app/vault/VaultFixedPrecisionBase.h b/src/test/app/vault/VaultFixedPrecisionBase.h index eb80668ed3..e153254332 100644 --- a/src/test/app/vault/VaultFixedPrecisionBase.h +++ b/src/test/app/vault/VaultFixedPrecisionBase.h @@ -3,43 +3,29 @@ #include #include #include -#include #include -#include #include #include #include -#include -#include #include #include #include -#include #include -#include #include #include #include -#include #include -#include #include #include #include #include // IWYU pragma: keep -#include -#include #include -#include -#include #include #include -#include #include #include -#include namespace xrpl { From ade43a4b9ec9b2318411bb761803746527d5a8e4 Mon Sep 17 00:00:00 2001 From: Vito <5780819+Tapanito@users.noreply.github.com> Date: Thu, 1 Oct 2026 17:01:33 +0200 Subject: [PATCH 2/4] style: Fix clang-tidy findings in FixedPrecision headers --- include/xrpl/ledger/helpers/LendingHelpers.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/xrpl/ledger/helpers/LendingHelpers.h b/include/xrpl/ledger/helpers/LendingHelpers.h index 3ca053469f..6ca7163c0d 100644 --- a/include/xrpl/ledger/helpers/LendingHelpers.h +++ b/include/xrpl/ledger/helpers/LendingHelpers.h @@ -11,6 +11,7 @@ #include #include #include // IWYU pragma: keep +#include #include #include #include From c29cbaec9d841a88ff5cb6474d2817e520cfda21 Mon Sep 17 00:00:00 2001 From: Vito <5780819+Tapanito@users.noreply.github.com> Date: Thu, 1 Oct 2026 17:01:37 +0200 Subject: [PATCH 3/4] style: Fix clang-tidy findings in FixedPrecision headers --- src/test/app/lending/LoanFixedPrecisionBase.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/test/app/lending/LoanFixedPrecisionBase.h b/src/test/app/lending/LoanFixedPrecisionBase.h index 96087caa8e..d314cbe5ca 100644 --- a/src/test/app/lending/LoanFixedPrecisionBase.h +++ b/src/test/app/lending/LoanFixedPrecisionBase.h @@ -14,9 +14,8 @@ #include #include -#include +#include #include -#include #include #include #include From db79ce5d45b63b998e5ae5b1f5982ebda0ccc433 Mon Sep 17 00:00:00 2001 From: Vito <5780819+Tapanito@users.noreply.github.com> Date: Thu, 1 Oct 2026 17:01:40 +0200 Subject: [PATCH 4/4] style: Fix clang-tidy findings in FixedPrecision headers --- src/test/app/lending/LoanPayFixedPrecisionBase.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/app/lending/LoanPayFixedPrecisionBase.h b/src/test/app/lending/LoanPayFixedPrecisionBase.h index 9bd572aab2..39ddab0724 100644 --- a/src/test/app/lending/LoanPayFixedPrecisionBase.h +++ b/src/test/app/lending/LoanPayFixedPrecisionBase.h @@ -1,14 +1,12 @@ #pragma once #include -#include +#include #include #include #include #include #include -#include -#include #include #include @@ -16,7 +14,9 @@ #include #include #include +#include #include +#include #include #include #include