From 04832dbc02b0796237be4ad3b18472dc436eb4ff Mon Sep 17 00:00:00 2001
From: Zheng Shao <zshao@fb.com>
Date: Tue, 25 Dec 2012 17:33:15 -0800
Subject: [PATCH] sst_dump: Fix incorrect cmd args parsing

Summary: The current parsing logic ignores any additional chars after the arg.

Test Plan: "./sst_dump --verify_checksumAAA" now outputs error.

Reviewers: dhruba, sheki, emayanke

Reviewed By: dhruba

CC: leveldb

Differential Revision: https://reviews.facebook.net/D7611
---
 tools/sst_dump.cc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/sst_dump.cc b/tools/sst_dump.cc
index b0abcb69f8..d78c559001 100644
--- a/tools/sst_dump.cc
+++ b/tools/sst_dump.cc
@@ -105,12 +105,11 @@ int main(int argc, char** argv) {
   {
     if (strncmp(argv[i], "--file=", 7) == 0) {
       dir_or_file = argv[i] + 7;
-    } else if (strncmp(argv[i], "--output_hex", 12) == 0) {
+    } else if (strcmp(argv[i], "--output_hex") == 0) {
       output_hex = true;
     } else if (sscanf(argv[i], "--read_num=%ld%c", &n, &junk) == 1) {
       read_num = n;
-    } else if (strncmp(argv[i], "--verify_checksum",
-        strlen("--verify_checksum")) == 0) {
+    } else if (strcmp(argv[i], "--verify_checksum") == 0) {
       verify_checksum = true;
     } else if (strncmp(argv[i], "--command=", 10) == 0) {
       command = argv[i] + 10;