ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-04 01:06:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Use isFlag where possible instead of bitwise math (#7278)

Browse Source
This commit is contained in:
Mayukha Vadari
2026-05-15 10:00:13 -04:00
committed by GitHub
parent 15b3ed1ae7
commit 028f0cb5da
49 changed files with 242 additions and 314 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/app/Credentials_test.cpp
View File

@@ -142,7 +142,7 @@ struct Credentials_test : public beast::unit_test::Suite
BEAST_EXPECT(sleCred->getAccountID(sfSubject) == issuer.id());
BEAST_EXPECT(sleCred->getAccountID(sfIssuer) == issuer.id());
BEAST_EXPECT((sleCred->getFieldU32(sfFlags) & lsfAccepted));
BEAST_EXPECT(sleCred->isFlag(lsfAccepted));
BEAST_EXPECT(
sleCred->getFieldU64(sfIssuerNode) == sleCred->getFieldU64(sfSubjectNode));
BEAST_EXPECT(ownerCount(env, issuer) == 1);
@@ -1074,7 +1074,7 @@ struct Credentials_test : public beast::unit_test::Suite
// Verify credential exists and is accepted
{
auto const sleCred = env.current()->read(credKeylet);
BEAST_EXPECT(sleCred && sleCred->getFlags() & lsfAccepted);
BEAST_EXPECT(sleCred && sleCred->isFlag(lsfAccepted));
}
// Create DepositPreauth
@@ -1127,11 +1127,11 @@ struct Credentials_test : public beast::unit_test::Suite
auto const dpTer = xrpl::verifyDepositPreauth(*stx, av, subject, becky, {}, j);
auto sleCredAfter = av.read(credKeylet);
BEAST_EXPECT(sleCredAfter && (sleCredAfter->getFlags() & lsfAccepted));
BEAST_EXPECT(sleCredAfter && sleCredAfter->isFlag(lsfAccepted));
auto const domTer = xrpl::verifyValidDomain(av, subject.id(), domain, j);
sleCredAfter = av.read(credKeylet);
BEAST_EXPECT(sleCredAfter && (sleCredAfter->getFlags() & lsfAccepted));
BEAST_EXPECT(sleCredAfter && sleCredAfter->isFlag(lsfAccepted));
if (fixEnabled)
{