From 28f50cb7cffce7579cdd60f1fbbbe7b8d7f50a9d Mon Sep 17 00:00:00 2001 From: yinyiqian1 Date: Sat, 10 May 2025 10:36:11 -0400 Subject: [PATCH 1/2] fix: enable LedgerStateFix for delegation (#5427) --- include/xrpl/protocol/detail/transactions.macro | 2 +- src/test/app/Delegate_test.cpp | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/xrpl/protocol/detail/transactions.macro b/include/xrpl/protocol/detail/transactions.macro index 61479611aa..54f97f942f 100644 --- a/include/xrpl/protocol/detail/transactions.macro +++ b/include/xrpl/protocol/detail/transactions.macro @@ -396,7 +396,7 @@ TRANSACTION(ttORACLE_DELETE, 52, OracleDelete, Delegation::delegatable, ({ })) /** This transaction type fixes a problem in the ledger state */ -TRANSACTION(ttLEDGER_STATE_FIX, 53, LedgerStateFix, Delegation::notDelegatable, ({ +TRANSACTION(ttLEDGER_STATE_FIX, 53, LedgerStateFix, Delegation::delegatable, ({ {sfLedgerFixType, soeREQUIRED}, {sfOwner, soeOPTIONAL}, })) diff --git a/src/test/app/Delegate_test.cpp b/src/test/app/Delegate_test.cpp index c8415a558a..5136627148 100644 --- a/src/test/app/Delegate_test.cpp +++ b/src/test/app/Delegate_test.cpp @@ -215,9 +215,7 @@ class Delegate_test : public beast::unit_test::suite ter(terNO_ACCOUNT)); } - // for security reasons, AccountSet, SetRegularKey, SignerListSet, - // AccountDelete, DelegateSet are prohibited to be delegated to - // other accounts. + // non-delegatable transaction { env(delegate::set(gw, alice, {"SetRegularKey"}), ter(tecNO_PERMISSION)); @@ -229,6 +227,10 @@ class Delegate_test : public beast::unit_test::suite ter(tecNO_PERMISSION)); env(delegate::set(gw, alice, {"SetRegularKey"}), ter(tecNO_PERMISSION)); + env(delegate::set(gw, alice, {"EnableAmendment"}), + ter(tecNO_PERMISSION)); + env(delegate::set(gw, alice, {"UNLModify"}), ter(tecNO_PERMISSION)); + env(delegate::set(gw, alice, {"SetFee"}), ter(tecNO_PERMISSION)); } } From c6c7c843559c31954a473c51f3b9b32447a85d4c Mon Sep 17 00:00:00 2001 From: Bart Date: Mon, 12 May 2025 13:42:03 +0100 Subject: [PATCH 2/2] Configure CODEOWNERS for changes to RPC code (#5266) To ensure changes to any RPC-related code are compatible with other services, such as Clio, the RPC team will be required to review them. --- .github/CODEOWNERS | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000000..b6ecc5b7d4 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,8 @@ +# Allow anyone to review any change by default. +* + +# Require the rpc-reviewers team to review changes to the rpc code. +include/libxrpl/protocol/ @xrplf/rpc-reviewers +src/libxrpl/protocol/ @xrplf/rpc-reviewers +src/xrpld/rpc/ @xrplf/rpc-reviewers +src/xrpld/app/misc/ @xrplf/rpc-reviewers