diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000000..b6ecc5b7d4 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,8 @@ +# Allow anyone to review any change by default. +* + +# Require the rpc-reviewers team to review changes to the rpc code. +include/libxrpl/protocol/ @xrplf/rpc-reviewers +src/libxrpl/protocol/ @xrplf/rpc-reviewers +src/xrpld/rpc/ @xrplf/rpc-reviewers +src/xrpld/app/misc/ @xrplf/rpc-reviewers diff --git a/include/xrpl/protocol/detail/transactions.macro b/include/xrpl/protocol/detail/transactions.macro index 87e56ac31d..0f614df692 100644 --- a/include/xrpl/protocol/detail/transactions.macro +++ b/include/xrpl/protocol/detail/transactions.macro @@ -396,7 +396,7 @@ TRANSACTION(ttORACLE_DELETE, 52, OracleDelete, Delegation::delegatable, ({ })) /** This transaction type fixes a problem in the ledger state */ -TRANSACTION(ttLEDGER_STATE_FIX, 53, LedgerStateFix, Delegation::notDelegatable, ({ +TRANSACTION(ttLEDGER_STATE_FIX, 53, LedgerStateFix, Delegation::delegatable, ({ {sfLedgerFixType, soeREQUIRED}, {sfOwner, soeOPTIONAL}, })) diff --git a/src/test/app/Delegate_test.cpp b/src/test/app/Delegate_test.cpp index c8415a558a..5136627148 100644 --- a/src/test/app/Delegate_test.cpp +++ b/src/test/app/Delegate_test.cpp @@ -215,9 +215,7 @@ class Delegate_test : public beast::unit_test::suite ter(terNO_ACCOUNT)); } - // for security reasons, AccountSet, SetRegularKey, SignerListSet, - // AccountDelete, DelegateSet are prohibited to be delegated to - // other accounts. + // non-delegatable transaction { env(delegate::set(gw, alice, {"SetRegularKey"}), ter(tecNO_PERMISSION)); @@ -229,6 +227,10 @@ class Delegate_test : public beast::unit_test::suite ter(tecNO_PERMISSION)); env(delegate::set(gw, alice, {"SetRegularKey"}), ter(tecNO_PERMISSION)); + env(delegate::set(gw, alice, {"EnableAmendment"}), + ter(tecNO_PERMISSION)); + env(delegate::set(gw, alice, {"UNLModify"}), ter(tecNO_PERMISSION)); + env(delegate::set(gw, alice, {"SetFee"}), ter(tecNO_PERMISSION)); } }