ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add DepositPreauth ledger type and transaction (RIPD-1624):

Browse Source 
The lsfDepositAuth flag limits the AccountIDs that can deposit into
the account that has the flag set.  The original design only
allowed deposits to complete if the account with the flag set also
signed the transaction that caused the deposit.

The DepositPreauth ledger type allows an account with the
lsfDepositAuth flag set to preauthorize additional accounts.
This preauthorization allows them to sign deposits as well.  An
account can add DepositPreauth objects to the ledger (and remove
them as well) using the DepositPreauth transaction.
This commit is contained in:
Scott Schurr
2018-04-20 13:16:17 -07:00
committed by seelabs
parent b444196bf9
commit 008ff67ac2
56 changed files with 1589 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files

79
src/test/app/PayChan_test.cpp
View File

@@ -644,7 +644,7 @@ struct PayChan_test : public beast::unit_test::suite
{
// Create a channel where dst disallows XRP. Ignore that flag,
// since it's just advisory.
Env env (*this);
Env env (*this, supported_amendments());
env.fund (XRP (10000), alice, bob);
env (fset (bob, asfDisallowXRP));
env (create (alice, bob, XRP (1000), 3600s, alice.pk()));
@@ -669,7 +669,7 @@ struct PayChan_test : public beast::unit_test::suite
// Claim to a channel where dst disallows XRP (channel is
// created before disallow xrp is set). Ignore that flag
// since it is just advisory.
Env env (*this);
Env env (*this, supported_amendments());
env.fund (XRP (10000), alice, bob);
env (create (alice, bob, XRP (1000), 3600s, alice.pk()));
auto const chan = channel (*env.current (), alice, bob);
@@ -716,10 +716,11 @@ struct PayChan_test : public beast::unit_test::suite
auto const alice = Account ("alice");
auto const bob = Account ("bob");
auto const carol = Account ("carol");
auto USDA = alice["USD"];
{
Env env (*this);
env.fund (XRP (10000), alice, bob);
env.fund (XRP (10000), alice, bob, carol);
env (fset (bob, asfDepositAuth));
env.close();
@@ -757,22 +758,76 @@ struct PayChan_test : public beast::unit_test::suite
env.close();
BEAST_EXPECT (env.balance (bob) == preBob);
// bob claims but omits the signature. Fails because only
// alice can claim without a signature.
env (claim (bob, chan, delta, delta), ter (temBAD_SIGNATURE));
env.close();
// bob claims with signature. Succeeds even though bob's
// lsfDepositAuth flag is set since bob signed the transaction.
// lsfDepositAuth flag is set since bob submitted the
// transaction.
env (claim (bob, chan, delta, delta, Slice (sig), pk));
env.close();
BEAST_EXPECT (env.balance (bob) == preBob + delta - baseFee);
}
{
// Explore the limits of deposit preauthorization.
auto const delta = XRP (600).value();
auto const sig = signClaimAuth (pk, alice.sk (), chan, delta);
// bob clears lsfDepositAuth. Now alice can use an unsigned claim.
env (fclear (bob, asfDepositAuth));
env.close();
// carol claims and fails. Only channel participants (bob or
// alice) may claim.
env (claim (carol, chan,
delta, delta, Slice (sig), pk), ter (tecNO_PERMISSION));
env.close();
// alice claims successfully.
env (claim (alice, chan, XRP (800).value(), XRP (800).value()));
env.close();
BEAST_EXPECT (
env.balance (bob) == preBob + XRP (800) - (2 * baseFee));
// bob preauthorizes carol for deposit. But after that carol
// still can't claim since only channel participants may claim.
env(deposit::auth (bob, carol));
env.close();
env (claim (carol, chan,
delta, delta, Slice (sig), pk), ter (tecNO_PERMISSION));
// Since alice is not preauthorized she also may not claim
// for bob.
env (claim (alice, chan, delta, delta,
Slice (sig), pk), ter (tecNO_PERMISSION));
env.close();
// However if bob preauthorizes alice for deposit then she can
// successfully submit a claim.
env(deposit::auth (bob, alice));
env.close();
env (claim (alice, chan, delta, delta, Slice (sig), pk));
env.close();
BEAST_EXPECT (
env.balance (bob) == preBob + delta - (3 * baseFee));
}
{
// bob removes preauthorization of alice. Once again she
// cannot submit a claim.
auto const delta = XRP (800).value();
env(deposit::unauth (bob, alice));
env.close();
// alice claims and fails since she is no longer preauthorized.
env (claim (alice, chan, delta, delta), ter (tecNO_PERMISSION));
env.close();
// bob clears lsfDepositAuth. Now alice can claim.
env (fclear (bob, asfDepositAuth));
env.close();
// alice claims successfully.
env (claim (alice, chan, delta, delta));
env.close();
BEAST_EXPECT (
env.balance (bob) == preBob + XRP (800) - (5 * baseFee));
}
}
}