ARCHIVE/hpcore
1
0
Fork 0
mirror of https://github.com/EvernodeXRPL/hpcore.git synced 2026-04-29 15:37:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Peer message flatbuffer parsing fixes. (#294)

Browse Source
This commit is contained in:
Ravin Perera
2021-04-25 21:16:42 +05:30
committed by GitHub
parent e8d63c95f2
commit 78fb68e064
5 changed files with 20 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/p2p/peer_session_handler.cpp
View File

@@ -62,17 +62,13 @@ namespace p2p
}
const peer_message_info mi = p2pmsg::get_peer_message_info(message);
if (mi.type == p2pmsg::P2PMsgContent_NONE)
{
session.increment_metric(comm::SESSION_THRESHOLDS::MAX_BADMSGS_PER_MINUTE, 1);
LOG_DEBUG << "Received invalid peer message type. " << session.display_name();
if (!mi.p2p_msg) // Message buffer will be null if peer message was too old.
return 0;
}
else if (!recent_peermsg_hashes.try_emplace(crypto::get_hash(message)))
if (!recent_peermsg_hashes.try_emplace(crypto::get_hash(message)))
{
session.increment_metric(comm::SESSION_THRESHOLDS::MAX_DUPMSGS_PER_MINUTE, 1);
LOG_DEBUG << "Duplicate peer message. " << session.display_name();
LOG_DEBUG << "Duplicate peer message. type:" << mi.type << " " << session.display_name();
return 0;
}
@@ -269,7 +265,7 @@ namespace p2p
else
{
session.increment_metric(comm::SESSION_THRESHOLDS::MAX_BADMSGS_PER_MINUTE, 1);
LOG_DEBUG << "Received invalid peer message type. " << session.display_name();
LOG_DEBUG << "Received invalid peer message type [" << mi.type << "]. " << session.display_name();
}
return 0;
}