ci: Use Nix-based images for all workflows except pre-commit (#3098)

.github/workflows/reusable-test.yml

@@ -13,11 +13,17 @@ on:
         required: true
         type: string
 
-      conan_profile:
-        description: Conan profile to use
+      compiler:
+        description: 'Compiler the binaries were built with ("gcc", "clang" or "apple-clang")'
         required: true
         type: string
 
+      sanitizers:
+        description: 'Sanitizers the binaries were built with ("address", "thread", "undefinedbehavior" or empty)'
+        required: false
+        type: string
+        default: ""
+
       build_type:
         description: Build type
         required: true
@@ -54,9 +60,19 @@ jobs:
         with:
           fetch-depth: 0
 
+      - name: Generate build identifier
+        uses: ./.github/actions/build-identifier
+        id: build_identifier
+        with:
+          build_type: ${{ inputs.build_type }}
+          compiler: ${{ inputs.compiler }}
+          # code_coverage is run inside build environment
+          code_coverage: false
+          sanitizers: ${{ inputs.sanitizers }}
+
       - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
         with:
-          name: clio_tests_${{ runner.os }}_${{ inputs.build_type }}_${{ inputs.conan_profile }}
+          name: clio_tests_${{ steps.build_identifier.outputs.build_identifier }}
 
       - name: Make clio_tests executable
         run: chmod +x ./clio_tests
@@ -67,11 +83,11 @@ jobs:
         run: ./clio_tests
 
       - name: Create an issue
-        if: ${{ steps.run_clio_tests.outcome == 'failure' && endsWith(inputs.conan_profile, 'san') }}
+        if: ${{ steps.run_clio_tests.outcome == 'failure' && inputs.sanitizers != '' }}
         uses: XRPLF/actions/create-issue@2b8bc36af85b88bca0dd7bfac2e2dc05f94ad712
         with:
-          title: "[${{ inputs.conan_profile }}] reported issues"
-          body: "Clio tests failed one or more sanitizer checks when built with `${{ inputs.conan_profile }}`."
+          title: "[${{ inputs.compiler }} ${{ inputs.sanitizers }}] reported issues"
+          body: "Clio tests failed one or more sanitizers checks when built with `${{ inputs.compiler }}` and the `${{ inputs.sanitizers }}` sanitizers."
           labels: "bug"
           assignees: "godexsoft,kuznetsss,mathbunnyru"
 
@@ -100,6 +116,20 @@ jobs:
         if: ${{ runner.os == 'macOS' }}
         uses: XRPLF/actions/cleanup-workspace@c7d9ce5ebb03c752a354889ecd870cadfc2b1cd4
 
+      - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+        with:
+          fetch-depth: 0
+
+      - name: Generate build identifier
+        uses: ./.github/actions/build-identifier
+        id: build_identifier
+        with:
+          build_type: ${{ inputs.build_type }}
+          compiler: ${{ inputs.compiler }}
+          # code_coverage is run inside build environment
+          code_coverage: false
+          sanitizers: ${{ inputs.sanitizers }}
+
       - name: Delete and start colima (macOS)
         # This is a temporary workaround for colima issues on macOS runners
         if: ${{ runner.os == 'macOS' }}
@@ -107,6 +137,12 @@ jobs:
           colima delete --force
           colima start
 
+      - name: Remove leftover scylladb container (macOS)
+        # A previous run that didn't clean up (e.g. a cancelled job) can leave the
+        # container behind, otherwise the name is still taken on the persistent runner.
+        if: ${{ runner.os == 'macOS' }}
+        run: docker rm --force scylladb || true
+
       - name: Spin up scylladb (macOS)
         if: ${{ runner.os == 'macOS' }}
         timeout-minutes: 1
@@ -132,7 +168,7 @@ jobs:
 
       - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
         with:
-          name: clio_integration_tests_${{ runner.os }}_${{ inputs.build_type }}_${{ inputs.conan_profile }}
+          name: clio_integration_tests_${{ steps.build_identifier.outputs.build_identifier }}
 
       - name: Run clio_integration_tests
         run: |