ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-06 17:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add field name to output of invalidParams for OneOf (#906)

Browse Source 
Fixes #901
This commit is contained in:
Alex Kremer
2023-10-09 13:26:54 +01:00
committed by GitHub
parent 91ad1ffc3b
commit f683b25f76
10 changed files with 20 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
unittests/rpc/handlers/AccountObjectsTests.cpp
View File

@@ -85,7 +85,7 @@ generateTestValuesForParametersTest()
"TypeInvalid",
R"({"account":"rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun", "type":"wrong"})",
"invalidParams",
"Invalid parameters."},
"Invalid field 'type'."},
AccountObjectsParamTestCaseBundle{
"LedgerHashInvalid",
R"({"account":"rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun", "ledger_hash":"1"})",

10
unittests/rpc/handlers/BookOffersTests.cpp
View File

@@ -256,7 +256,7 @@ generateParameterBookOffersTestBundles()
"taker": "123"
})",
"invalidParams",
"Invalid field 'taker'"},
"Invalid field 'taker'."},
ParameterTestBundle{
"TakerNotString",
R"({
@@ -272,7 +272,7 @@ generateParameterBookOffersTestBundles()
"taker": 123
})",
"invalidParams",
"Invalid field 'taker'"},
"Invalid field 'taker'."},
ParameterTestBundle{
"LimitNotInt",
R"({
@@ -384,8 +384,7 @@ generateParameterBookOffersTestBundles()
}
})",
"srcIsrMalformed",
"Unneeded field 'taker_pays.issuer' for XRP currency "
"specification."},
"Unneeded field 'taker_pays.issuer' for XRP currency specification."},
ParameterTestBundle{
"PaysCurrencyWithXRPIssuer",
R"({
@@ -430,8 +429,7 @@ generateParameterBookOffersTestBundles()
}
})",
"dstIsrMalformed",
"Unneeded field 'taker_gets.issuer' for XRP currency "
"specification."},
"Unneeded field 'taker_gets.issuer' for XRP currency specification."},
ParameterTestBundle{
"BadMarket",
R"({

6
unittests/rpc/handlers/SubscribeTests.cpp
View File

@@ -410,8 +410,7 @@ generateTestValuesForParametersTest()
]
})",
"dstIsrMalformed",
"Unneeded field 'taker_gets.issuer' for XRP currency "
"specification."},
"Unneeded field 'taker_gets.issuer' for XRP currency specification."},
SubscribeParamTestCaseBundle{
"BooksItemTakerPaysXRPHasIssuer",
R"({
@@ -430,8 +429,7 @@ generateTestValuesForParametersTest()
]
})",
"srcIsrMalformed",
"Unneeded field 'taker_pays.issuer' for XRP currency "
"specification."},
"Unneeded field 'taker_pays.issuer' for XRP currency specification."},
SubscribeParamTestCaseBundle{
"BooksItemBadMartket",
R"({

6
unittests/rpc/handlers/UnsubscribeTests.cpp
View File

@@ -405,8 +405,7 @@ generateTestValuesForParametersTest()
]
})",
"dstIsrMalformed",
"Unneeded field 'taker_gets.issuer' for XRP currency "
"specification."},
"Unneeded field 'taker_gets.issuer' for XRP currency specification."},
UnsubscribeParamTestCaseBundle{
"BooksItemTakerPaysXRPHasIssuer",
R"({
@@ -426,8 +425,7 @@ generateTestValuesForParametersTest()
]
})",
"srcIsrMalformed",
"Unneeded field 'taker_pays.issuer' for XRP currency "
"specification."},
"Unneeded field 'taker_pays.issuer' for XRP currency specification."},
UnsubscribeParamTestCaseBundle{
"BooksItemBadMartket",
R"({