ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-06 17:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: setRange in tests (#1763)

Browse Source 
There are a few files that cannot move the setRange into constructor of
the test because either the place that calls setRange matters or tests
checks range doesn't exist
This commit is contained in:
Peter Chen
2024-11-29 09:27:45 -05:00
committed by GitHub
parent afb0c7fee2
commit f62fadc9f9
28 changed files with 171 additions and 493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/unit/rpc/handlers/TransactionEntryTests.cpp
View File

@@ -44,7 +44,12 @@ constexpr static auto ACCOUNT = "rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn";
constexpr static auto ACCOUNT2 = "rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun";
constexpr static auto CURRENCY = "0158415500000000C1F76FF6ECB0BAC600000000";
class RPCTransactionEntryHandlerTest : public HandlerBaseTest {};
struct RPCTransactionEntryHandlerTest : HandlerBaseTest {
RPCTransactionEntryHandlerTest()
{
backend->setRange(10, 30);
}
};
TEST_F(RPCTransactionEntryHandlerTest, TxHashNotProvide)
{
@@ -98,7 +103,6 @@ TEST_F(RPCTransactionEntryHandlerTest, NonExistLedgerViaLedgerHash)
// error case ledger non exist via index
TEST_F(RPCTransactionEntryHandlerTest, NonExistLedgerViaLedgerIndex)
{
backend->setRange(10, 30);
// mock fetchLedgerBySequence return empty
ON_CALL(*backend, fetchLedgerBySequence).WillByDefault(Return(std::optional<ripple::LedgerHeader>{}));
EXPECT_CALL(*backend, fetchLedgerBySequence).Times(1);
@@ -121,7 +125,6 @@ TEST_F(RPCTransactionEntryHandlerTest, NonExistLedgerViaLedgerIndex)
TEST_F(RPCTransactionEntryHandlerTest, TXNotFound)
{
backend->setRange(10, 30);
ON_CALL(*backend, fetchLedgerBySequence).WillByDefault(Return(CreateLedgerHeader(INDEX, 30)));
EXPECT_CALL(*backend, fetchLedgerBySequence).Times(1);
ON_CALL(*backend, fetchTransaction(ripple::uint256{TXNID}, _))
@@ -154,7 +157,6 @@ TEST_F(RPCTransactionEntryHandlerTest, LedgerSeqNotMatch)
ON_CALL(*backend, fetchTransaction(ripple::uint256{TXNID}, _)).WillByDefault(Return(tx));
EXPECT_CALL(*backend, fetchTransaction).Times(1);
backend->setRange(10, 30);
ON_CALL(*backend, fetchLedgerBySequence).WillByDefault(Return(CreateLedgerHeader(INDEX, 30)));
EXPECT_CALL(*backend, fetchLedgerBySequence).Times(1);
@@ -232,7 +234,6 @@ TEST_F(RPCTransactionEntryHandlerTest, NormalPath)
ON_CALL(*backend, fetchTransaction(ripple::uint256{TXNID}, _)).WillByDefault(Return(tx));
EXPECT_CALL(*backend, fetchTransaction).Times(1);
backend->setRange(10, tx.ledgerSequence);
ON_CALL(*backend, fetchLedgerBySequence).WillByDefault(Return(CreateLedgerHeader(INDEX, tx.ledgerSequence)));
EXPECT_CALL(*backend, fetchLedgerBySequence).Times(1);
@@ -308,8 +309,6 @@ TEST_F(RPCTransactionEntryHandlerTest, NormalPathV2)
tx.date = 123456;
tx.ledgerSequence = 30;
EXPECT_CALL(*backend, fetchTransaction(ripple::uint256{TXNID}, _)).WillOnce(Return(tx));
backend->setRange(10, tx.ledgerSequence);
EXPECT_CALL(*backend, fetchLedgerBySequence).WillOnce(Return(CreateLedgerHeader(INDEX, tx.ledgerSequence)));
runSpawn([&, this](auto yield) {