ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-11-20 11:45:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: setRange in tests (#1763)

Browse Source 
There are a few files that cannot move the setRange into constructor of
the test because either the place that calls setRange matters or tests
checks range doesn't exist
This commit is contained in:
Peter Chen
2024-11-29 09:27:45 -05:00
committed by GitHub
parent afb0c7fee2
commit f62fadc9f9
28 changed files with 171 additions and 493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/unit/data/BackendInterfaceTests.cpp
View File

@@ -41,12 +41,16 @@ using namespace testing;
constexpr static auto MAXSEQ = 30;
constexpr static auto MINSEQ = 10;
struct BackendInterfaceTest : WithPrometheus, MockBackendTestNaggy, SyncAsioContextTest {};
struct BackendInterfaceTest : WithPrometheus, MockBackendTestNaggy, SyncAsioContextTest {
BackendInterfaceTest()
{
backend->setRange(MINSEQ, MAXSEQ);
}
};
TEST_F(BackendInterfaceTest, FetchFeesSuccessPath)
{
using namespace ripple;
backend->setRange(MINSEQ, MAXSEQ);
// New fee setting (after XRPFees amendment)
EXPECT_CALL(*backend, doFetchLedgerObject(keylet::fees().key, MAXSEQ, _))
@@ -65,7 +69,6 @@ TEST_F(BackendInterfaceTest, FetchFeesSuccessPath)
TEST_F(BackendInterfaceTest, FetchFeesLegacySuccessPath)
{
using namespace ripple;
backend->setRange(MINSEQ, MAXSEQ);
// Legacy fee setting (before XRPFees amendment)
EXPECT_CALL(*backend, doFetchLedgerObject(keylet::fees().key, MAXSEQ, _))
@@ -84,7 +87,6 @@ TEST_F(BackendInterfaceTest, FetchFeesLegacySuccessPath)
TEST_F(BackendInterfaceTest, FetchLedgerPageSuccessPath)
{
using namespace ripple;
backend->setRange(MINSEQ, MAXSEQ);
auto state = etl::SystemState{};
backend->setCorruptionDetector(etl::CorruptionDetector{state, backend->cache()});
@@ -102,7 +104,6 @@ TEST_F(BackendInterfaceTest, FetchLedgerPageSuccessPath)
TEST_F(BackendInterfaceTest, FetchLedgerPageDisablesCacheOnMissingData)
{
using namespace ripple;
backend->setRange(MINSEQ, MAXSEQ);
auto state = etl::SystemState{};
backend->setCorruptionDetector(etl::CorruptionDetector{state, backend->cache()});
@@ -123,7 +124,6 @@ TEST_F(BackendInterfaceTest, FetchLedgerPageDisablesCacheOnMissingData)
TEST_F(BackendInterfaceTest, FetchLedgerPageWithoutCorruptionDetectorDoesNotDisableCacheOnMissingData)
{
using namespace ripple;
backend->setRange(MINSEQ, MAXSEQ);
EXPECT_FALSE(backend->cache().isDisabled());
EXPECT_CALL(*backend, doFetchSuccessorKey(_, _, _))