ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-11-12 07:45:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Return domainMalformed when domain is malformed (#2228)

Browse Source 
Fix: https://github.com/XRPLF/clio/issues/2222

Code in rippled to handle errors:
https://github.com/XRPLF/rippled/blob/2.5.0-rc1/src/xrpld/rpc/handlers/BookOffers.cpp#L183
This commit is contained in:
Ayaz Salikhov
2025-06-16 15:42:19 +01:00
committed by GitHub
parent 95698ee2de
commit f58c85d203
2 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/rpc/handlers/BookOffers.hpp
View File

@@ -148,11 +148,14 @@ public:
validation::CustomValidators::accountValidator, validation::CustomValidators::accountValidator,
Status(RippledError::rpcINVALID_PARAMS, "Invalid field 'taker'.") Status(RippledError::rpcINVALID_PARAMS, "Invalid field 'taker'.")
}}, }},
{ {JS(domain),
JS(domain), meta::WithCustomError{
validation::Type<std::string>{}, validation::Type<std::string>{}, Status(RippledError::rpcDOMAIN_MALFORMED, "Unable to parse domain.")
validation::CustomValidators::uint256HexStringValidator, },
}, meta::WithCustomError{
validation::CustomValidators::uint256HexStringValidator,
Status(RippledError::rpcDOMAIN_MALFORMED, "Unable to parse domain.")
}},
{JS(limit), {JS(limit),
validation::Type<uint32_t>{}, validation::Type<uint32_t>{},
validation::Min(1u), validation::Min(1u),

12
tests/unit/rpc/handlers/BookOffersTests.cpp
View File

@@ -327,8 +327,8 @@ generateParameterBookOffersTestBundles()
}, },
"domain": 0 "domain": 0
})JSON", })JSON",
.expectedError = "invalidParams", .expectedError = "domainMalformed",
.expectedErrorMessage = "Invalid parameters." .expectedErrorMessage = "Unable to parse domain."
}, },
ParameterTestBundle{ ParameterTestBundle{
.testName = "Domain_InvalidInt", .testName = "Domain_InvalidInt",
@@ -344,8 +344,8 @@ generateParameterBookOffersTestBundles()
}, },
"domain": "123" "domain": "123"
})JSON", })JSON",
.expectedError = "invalidParams", .expectedError = "domainMalformed",
.expectedErrorMessage = "domainMalformed" .expectedErrorMessage = "Unable to parse domain."
}, },
ParameterTestBundle{ ParameterTestBundle{
.testName = "Domain_InvalidObject", .testName = "Domain_InvalidObject",
@@ -361,8 +361,8 @@ generateParameterBookOffersTestBundles()
}, },
"domain": {} "domain": {}
})JSON", })JSON",
.expectedError = "invalidParams", .expectedError = "domainMalformed",
.expectedErrorMessage = "Invalid parameters." .expectedErrorMessage = "Unable to parse domain."
}, },
ParameterTestBundle{ ParameterTestBundle{
.testName = "LimitNotInt", .testName = "LimitNotInt",