ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-11-21 04:05:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

account_offer in new RPC framework (#567)

Browse Source 
Fixes #569
This commit is contained in:
cyan317
2023-03-29 16:40:51 +01:00
committed by GitHub
parent 75c2011845
commit e9937fab76
20 changed files with 1300 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
unittests/rpc/BaseTests.cpp
View File

@@ -25,6 +25,7 @@
#include <rpc/common/Validators.h>
#include <boost/json/parse.hpp>
#include <fmt/core.h>
#include <gtest/gtest.h>
#include <optional>
@@ -210,6 +211,9 @@ TEST_F(RPCBaseTest, ArrayAtValidator)
{"arr", Required{}, Type<json::array>{}, ValidateArrayAt{0, {
{"limit", Required{}, Type<uint32_t>{}, Between<uint32_t>{0, 100}},
}}},
{"arr2", ValidateArrayAt{0, {
{"limit", Required{}, Type<uint32_t>{}, Between<uint32_t>{0, 100}},
}}},
};
// clang-format on
@@ -218,6 +222,13 @@ TEST_F(RPCBaseTest, ArrayAtValidator)
auto failingInput = json::parse(R"({ "arr": [{"limit": "not int"}] })");
ASSERT_FALSE(spec.validate(failingInput));
failingInput =
json::parse(R"({ "arr": [{"limit": 42}] ,"arr2": "not array type" })");
ASSERT_FALSE(spec.validate(failingInput));
failingInput = json::parse(R"({ "arr": [] })");
ASSERT_FALSE(spec.validate(failingInput));
}
TEST_F(RPCBaseTest, IfTypeValidator)
@@ -231,7 +242,10 @@ TEST_F(RPCBaseTest, IfTypeValidator)
Section{{ "limit2", Required{}, Type<uint32_t>{}, Between<uint32_t>{0, 100}}}
},
IfType<std::string>{Uint256HexStringValidator,}
}};
},
{"mix2",Section{{ "limit", Required{}, Type<uint32_t>{}, Between<uint32_t>{0, 100}}},
Type<std::string,json::object>{}}
};
// clang-format on
// if json object pass
auto passingInput =
@@ -256,6 +270,10 @@ TEST_F(RPCBaseTest, IfTypeValidator)
// type check fail
failingInput = json::parse(R"({ "mix": 1213 })");
ASSERT_FALSE(spec.validate(failingInput));
failingInput =
json::parse(R"({ "mix": {"limit": 42, "limit2": 22} , "mix2": 1213 })");
ASSERT_FALSE(spec.validate(failingInput));
}
TEST_F(RPCBaseTest, WithCustomError)
@@ -329,6 +347,11 @@ TEST_F(RPCBaseTest, LedgerIndexValidator)
auto err = spec.validate(failingInput);
ASSERT_FALSE(err);
ASSERT_EQ(err.error().message, "ledgerIndexMalformed");
failingInput = json::parse(R"({ "ledgerIndex": true })");
err = spec.validate(failingInput);
ASSERT_FALSE(err);
ASSERT_EQ(err.error().message, "ledgerIndexMalformed");
}
TEST_F(RPCBaseTest, AccountValidator)
@@ -356,10 +379,10 @@ TEST_F(RPCBaseTest, AccountValidator)
ASSERT_TRUE(spec.validate(passingInput));
}
TEST_F(RPCBaseTest, MarkerValidator)
TEST_F(RPCBaseTest, AccountMarkerValidator)
{
auto spec = RpcSpec{
{"marker", MarkerValidator},
{"marker", AccountMarkerValidator},
};
auto failingInput = json::parse(R"({ "marker": 256 })");
ASSERT_FALSE(spec.validate(failingInput));
@@ -413,3 +436,21 @@ TEST_F(RPCBaseTest, CurrencyValidator)
ASSERT_FALSE(err);
ASSERT_EQ(err.error().message, "malformedCurrency");
}
TEST_F(RPCBaseTest, IssuerValidator)
{
auto const spec = RpcSpec{{"issuer", IssuerValidator}};
auto passingInput =
json::parse(R"({ "issuer": "rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn"})");
ASSERT_TRUE(spec.validate(passingInput));
auto failingInput = json::parse(R"({ "issuer": 256})");
auto err = spec.validate(failingInput);
ASSERT_FALSE(err);
ASSERT_EQ(err.error().message, "issuerNotString");
failingInput = json::parse(
fmt::format(R"({{ "issuer": "{}"}})", toBase58(ripple::noAccount())));
err = spec.validate(failingInput);
ASSERT_FALSE(err);
}