ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-11-21 04:05:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove "strict" (#755)

Browse Source 
Fixes #756
This commit is contained in:
cyan317
2023-07-11 13:21:56 +01:00
committed by GitHub
parent 7710468f37
commit e79425bc21
8 changed files with 4 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/rpc/handlers/AccountCurrencies.h
View File

@@ -72,9 +72,7 @@ public:
static auto const rpcSpec = RpcSpec{
{JS(account), validation::Required{}, validation::AccountValidator},
{JS(ledger_hash), validation::Uint256HexStringValidator},
{JS(ledger_index), validation::LedgerIndexValidator},
{JS(strict), meta::IfType<bool>{validation::NotSupported{false}}},
};
{JS(ledger_index), validation::LedgerIndexValidator}};
return rpcSpec;
}

4
src/rpc/handlers/AccountInfo.h
View File

@@ -90,9 +90,7 @@ public:
{JS(ident), validation::AccountValidator},
{JS(ledger_hash), validation::Uint256HexStringValidator},
{JS(ledger_index), validation::LedgerIndexValidator},
{JS(signer_lists), validation::Type<bool>{}},
{JS(strict), meta::IfType<bool>{validation::NotSupported{false}}},
};
{JS(signer_lists), validation::Type<bool>{}}};
return rpcSpec;
}

4
src/rpc/handlers/AccountOffers.h
View File

@@ -84,9 +84,7 @@ public:
{JS(ledger_hash), validation::Uint256HexStringValidator},
{JS(ledger_index), validation::LedgerIndexValidator},
{JS(marker), validation::AccountMarkerValidator},
{JS(limit), validation::Type<uint32_t>{}, modifiers::Clamp<int32_t>{10, 400}},
{JS(strict), meta::IfType<bool>{validation::NotSupported{false}}},
};
{JS(limit), validation::Type<uint32_t>{}, modifiers::Clamp<int32_t>{10, 400}}};
return rpcSpec;
}

4
src/rpc/handlers/GatewayBalances.h
View File

@@ -106,9 +106,7 @@ public:
{JS(account), validation::Required{}, validation::AccountValidator},
{JS(ledger_hash), validation::Uint256HexStringValidator},
{JS(ledger_index), validation::LedgerIndexValidator},
{JS(hotwallet), hotWalletValidator},
{JS(strict), meta::IfType<bool>{validation::NotSupported{false}}},
};
{JS(hotwallet), hotWalletValidator}};
return rpcSpec;
}

24
unittests/rpc/handlers/AccountCurrenciesTest.cpp
View File

@@ -40,30 +40,6 @@ class RPCAccountCurrenciesHandlerTest : public HandlerBaseTest
{
};
TEST_F(RPCAccountCurrenciesHandlerTest, StrictSetToFalseUnsupported)
{
mockBackendPtr->updateRange(10); // min
mockBackendPtr->updateRange(30); // max
auto const static input = boost::json::parse(fmt::format(
R"({{
"account": "{}",
"strict": false
}})",
ACCOUNT));
auto const handler = AnyHandler{AccountCurrenciesHandler{mockBackendPtr}};
runSpawn([&](auto& yield) {
auto const output = handler.process(input, Context{std::ref(yield)});
ASSERT_FALSE(output);
auto const err = RPC::makeError(output.error());
EXPECT_EQ(err.at("error").as_string(), "notSupported");
EXPECT_EQ(err.at("error_message").as_string(), "Not supported field 'strict's value 'false'");
});
}
TEST_F(RPCAccountCurrenciesHandlerTest, AccountNotExist)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());

5
unittests/rpc/handlers/AccountInfoTest.cpp
View File

@@ -91,11 +91,6 @@ generateTestValuesForParametersTest()
R"({"ident":"rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun", "ledger_index":"a"})",
"invalidParams",
"ledgerIndexMalformed"},
AccountInfoParamTestCaseBundle{
"StrictFieldUnsupportedValue",
R"({"ident": "rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun", "strict": false})",
"notSupported",
"Not supported field 'strict's value 'false'"},
};
}

6
unittests/rpc/handlers/AccountOffersTest.cpp
View File

@@ -119,12 +119,6 @@ generateTestValuesForParametersTest()
"invalidParams",
"Malformed cursor.",
},
{
"StrictFieldUnsupportedValue",
R"({"account": "rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn", "strict": false})",
"notSupported",
"Not supported field 'strict's value 'false'",
},
};
}

12
unittests/rpc/handlers/GatewayBalancesTest.cpp
View File

@@ -170,18 +170,6 @@ generateParameterTestBundles()
ACCOUNT),
"invalidParams",
"hotwalletMalformed"},
ParameterTestBundle{
"StrictFieldUnsupportedValue",
fmt::format(
R"({{
"account": "{}",
"hotwallet": "{}",
"strict": false
}})",
ACCOUNT,
ACCOUNT2),
"notSupported",
"Not supported field 'strict's value 'false'"},
};
}