ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-04-29 15:37:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Duplicate messages when subscribe both accounts and proposed_accounts (#1415)

Browse Source 
Fix #1134
This commit is contained in:
cyan317
2024-05-21 09:04:46 +01:00
committed by GitHub
parent 36c6caa7c0
commit df17b429c5
8 changed files with 386 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/feed/SubscriptionManager.cpp
View File

@@ -59,24 +59,32 @@ void
SubscriptionManager::subProposedTransactions(SubscriberSharedPtr const& subscriber)
{
proposedTransactionFeed_.sub(subscriber);
// proposed_transactions subscribers not only receive the transaction json when it is proposed, but also the
// transaction json when it is validated. So the subscriber also subscribes to the transaction feed.
transactionFeed_.subProposed(subscriber);
}
void
SubscriptionManager::unsubProposedTransactions(SubscriberSharedPtr const& subscriber)
{
proposedTransactionFeed_.unsub(subscriber);
transactionFeed_.unsubProposed(subscriber);
}
void
SubscriptionManager::subProposedAccount(ripple::AccountID const& account, SubscriberSharedPtr const& subscriber)
{
proposedTransactionFeed_.sub(account, subscriber);
// Same as proposed_transactions subscribers, proposed_account subscribers also subscribe to the transaction feed to
// receive validated transaction feed. TransactionFeed class will filter out the sessions that have been sent to.
transactionFeed_.subProposed(account, subscriber);
}
void
SubscriptionManager::unsubProposedAccount(ripple::AccountID const& account, SubscriberSharedPtr const& subscriber)
{
proposedTransactionFeed_.unsub(account, subscriber);
transactionFeed_.unsubProposed(account, subscriber);
}
void