ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-01 17:15:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use "invalidParam" when "book_offers" taker format is wrong (#734)

Browse Source 
Fix #735
This commit is contained in:
cyan317
2023-07-05 17:25:17 +01:00
committed by GitHub
parent f4d8e18bf7
commit dcbc4577c2
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/rpc/handlers/BookOffers.h
View File

@@ -90,7 +90,10 @@ public:
{JS(issuer),
validation::WithCustomError{
validation::IssuerValidator, Status(RippledError::rpcSRC_ISR_MALFORMED)}}}},
{JS(taker), validation::AccountValidator},
// return INVALID_PARAMS if account format is wrong for "taker"
{JS(taker),
validation::WithCustomError{
validation::AccountValidator, Status(RippledError::rpcINVALID_PARAMS, "Invalid field 'taker'")}},
{JS(limit), validation::Type<uint32_t>{}, validation::Between{1, 100}},
{JS(ledger_hash), validation::Uint256HexStringValidator},
{JS(ledger_index), validation::LedgerIndexValidator},

6
unittests/rpc/handlers/BookOffersTest.cpp
View File

@@ -255,8 +255,8 @@ generateParameterBookOffersTestBundles()
},
"taker": "123"
})",
"actMalformed",
"takerMalformed"},
"invalidParams",
"Invalid field 'taker'"},
ParameterTestBundle{
"TakerNotString",
R"({
@@ -272,7 +272,7 @@ generateParameterBookOffersTestBundles()
"taker": 123
})",
"invalidParams",
"takerNotString"},
"Invalid field 'taker'"},
ParameterTestBundle{
"LimitNotInt",
R"({