ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-06-03 00:36:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Rename static constants (#3073)

Browse Source
This commit is contained in:
Alex Kremer
2026-05-13 12:09:06 +01:00
committed by GitHub
parent d056c72212
commit dbc98894ba
301 changed files with 6954 additions and 7117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/unit/data/BackendInterfaceTests.cpp
View File

@@ -21,15 +21,15 @@ using namespace testing;
namespace {
constexpr auto kMAX_SEQ = 30;
constexpr auto kMIN_SEQ = 10;
constexpr auto kMaxSeq = 30;
constexpr auto kMinSeq = 10;
} // namespace
struct BackendInterfaceTest : WithPrometheus, MockBackendTestNaggy, SyncAsioContextTest {
BackendInterfaceTest()
{
backend_->setRange(kMIN_SEQ, kMAX_SEQ);
backend_->setRange(kMinSeq, kMaxSeq);
}
};
@@ -38,11 +38,11 @@ TEST_F(BackendInterfaceTest, FetchFeesSuccessPath)
using namespace ripple;
// New fee setting (after XRPFees amendment)
EXPECT_CALL(*backend_, doFetchLedgerObject(keylet::fees().key, kMAX_SEQ, _))
EXPECT_CALL(*backend_, doFetchLedgerObject(keylet::fees().key, kMaxSeq, _))
.WillRepeatedly(Return(createFeeSettingBlob(XRPAmount(1), XRPAmount(2), XRPAmount(3), 0)));
runSpawn([this](auto yield) {
auto fees = backend_->fetchFees(kMAX_SEQ, yield);
auto fees = backend_->fetchFees(kMaxSeq, yield);
EXPECT_TRUE(fees.has_value());
EXPECT_EQ(fees->base, XRPAmount(1));
@@ -56,11 +56,11 @@ TEST_F(BackendInterfaceTest, FetchFeesLegacySuccessPath)
using namespace ripple;
// Legacy fee setting (before XRPFees amendment)
EXPECT_CALL(*backend_, doFetchLedgerObject(keylet::fees().key, kMAX_SEQ, _))
EXPECT_CALL(*backend_, doFetchLedgerObject(keylet::fees().key, kMaxSeq, _))
.WillRepeatedly(Return(createLegacyFeeSettingBlob(1, 2, 3, 4, 0)));
runSpawn([this](auto yield) {
auto fees = backend_->fetchFees(kMAX_SEQ, yield);
auto fees = backend_->fetchFees(kMaxSeq, yield);
EXPECT_TRUE(fees.has_value());
EXPECT_EQ(fees->base, XRPAmount(1));
@@ -86,7 +86,7 @@ TEST_F(BackendInterfaceTest, FetchLedgerPageSuccessPath)
.WillOnce(Return(std::vector<Blob>(10, Blob{'s'})));
runSpawn([this](auto yield) {
backend_->fetchLedgerPage(std::nullopt, kMAX_SEQ, 10, false, yield);
backend_->fetchLedgerPage(std::nullopt, kMaxSeq, 10, false, yield);
});
EXPECT_FALSE(backend_->cache().isDisabled());
}
@@ -121,7 +121,7 @@ TEST_F(BackendInterfaceTest, FetchLedgerPageDisablesCacheOnMissingData)
));
runSpawn([this](auto yield) {
backend_->fetchLedgerPage(std::nullopt, kMAX_SEQ, 10, false, yield);
backend_->fetchLedgerPage(std::nullopt, kMaxSeq, 10, false, yield);
});
EXPECT_TRUE(backend_->cache().isDisabled());
}
@@ -156,7 +156,7 @@ TEST_F(
));
runSpawn([this](auto yield) {
backend_->fetchLedgerPage(std::nullopt, kMAX_SEQ, 10, false, yield);
backend_->fetchLedgerPage(std::nullopt, kMaxSeq, 10, false, yield);
});
EXPECT_FALSE(backend_->cache().isDisabled());
}