From d1896518217b73ec2b0f3fbfa3bf12ea7cb07a50 Mon Sep 17 00:00:00 2001 From: Peter Chen <34582813+PeterChen13579@users.noreply.github.com> Date: Sat, 21 Sep 2024 10:47:37 -0400 Subject: [PATCH] fix: add no lint to ignore clang-tidy (#1660) Fixes build for [#1659](https://github.com/XRPLF/clio/actions/runs/10956058143/job/30421296417) --- src/util/newconfig/ConfigConstraints.hpp | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/util/newconfig/ConfigConstraints.hpp b/src/util/newconfig/ConfigConstraints.hpp index fdfa6969..2fe479f6 100644 --- a/src/util/newconfig/ConfigConstraints.hpp +++ b/src/util/newconfig/ConfigConstraints.hpp @@ -88,7 +88,7 @@ public: // see here for more info: // https://stackoverflow.com/questions/72835571/constexpr-c-error-destructor-used-before-its-definition // https://godbolt.org/z/eMdWThaMY - constexpr virtual ~Constraint() noexcept = default; + constexpr virtual ~Constraint() noexcept {}; // NOLINT(google-default-destructor) /** * @brief Check if the value meets the specific constraint. @@ -156,7 +156,8 @@ protected: class PortConstraint final : public Constraint { public: constexpr ~PortConstraint() override - = default; + { + } // NOLINT(google-default-destructor) private: /** @@ -187,7 +188,8 @@ private: class ValidIPConstraint final : public Constraint { public: constexpr ~ValidIPConstraint() override - = default; + { + } // NOLINT(google-default-destructor) private: /** @@ -228,7 +230,8 @@ public: } constexpr ~OneOf() override - = default; + { + } // NOLINT(google-default-destructor) private: /** @@ -283,7 +286,8 @@ public: } constexpr ~NumberValueConstraint() override - = default; + { + } // NOLINT(google-default-destructor) private: /** @@ -325,7 +329,8 @@ private: class PositiveDouble final : public Constraint { public: constexpr ~PositiveDouble() override - = default; + { + } // NOLINT(google-default-destructor) private: /**