refactor: remove old config (#2097)

fixes #1805 --------- Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com> Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com> Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com>
2025-12-06 17:27:58 +00:00 · 2025-05-15 11:53:47 -04:00
parent 8cbbf6689d
commit cdb5882688
151 changed files with 385 additions and 1444 deletions
--- a/tests/unit/util/config/ArrayTests.cpp
+++ b/tests/unit/util/config/ArrayTests.cpp
@@ -0,0 +1,131 @@
+//------------------------------------------------------------------------------
+/*
+    This file is part of clio: https://github.com/XRPLF/clio
+    Copyright (c) 2024, the clio developers.
+
+    Permission to use, copy, modify, and distribute this software for any
+    purpose with or without fee is hereby granted, provided that the above
+    copyright notice and this permission notice appear in all copies.
+
+    THE  SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+    WITH  REGARD  TO  THIS  SOFTWARE  INCLUDING  ALL  IMPLIED  WARRANTIES  OF
+    MERCHANTABILITY  AND  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+    ANY  SPECIAL,  DIRECT,  INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+    WHATSOEVER  RESULTING  FROM  LOSS  OF USE, DATA OR PROFITS, WHETHER IN AN
+    ACTION  OF  CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+*/
+//==============================================================================
+
+#include "util/MockAssert.hpp"
+#include "util/config/Array.hpp"
+#include "util/config/ConfigConstraints.hpp"
+#include "util/config/ConfigValue.hpp"
+#include "util/config/Types.hpp"
+#include "util/config/ValueView.hpp"
+
+#include <gtest/gtest.h>
+
+#include <algorithm>
+#include <cstdint>
+#include <vector>
+
+using namespace util::config;
+
+TEST(ArrayTest, prefix)
+{
+    EXPECT_EQ(Array::prefix("foo.[]"), "foo.[]");
+    EXPECT_EQ(Array::prefix("foo.[].bar"), "foo.[]");
+    EXPECT_EQ(Array::prefix("foo.bar.[].baz"), "foo.bar.[]");
+}
+
+struct ArrayAssertTest : common::util::WithMockAssert {};
+
+TEST_F(ArrayAssertTest, prefix)
+{
+    EXPECT_CLIO_ASSERT_FAIL(Array::prefix("foo.bar"));
+}
+
+TEST(ArrayTest, addSingleValue)
+{
+    auto arr = Array{ConfigValue{ConfigType::Double}};
+    ASSERT_FALSE(arr.addValue(111.11));
+    EXPECT_EQ(arr.size(), 1);
+}
+
+TEST(ArrayTest, addAndCheckMultipleValues)
+{
+    auto arr = Array{ConfigValue{ConfigType::Double}};
+    ASSERT_FALSE(arr.addValue(111.11));
+    ASSERT_FALSE(arr.addValue(222.22));
+    ASSERT_FALSE(arr.addValue(333.33));
+    EXPECT_EQ(arr.size(), 3);
+
+    auto const cv = arr.at(0);
+    ValueView const vv{cv};
+    EXPECT_EQ(vv.asDouble(), 111.11);
+
+    auto const cv2 = arr.at(1);
+    ValueView const vv2{cv2};
+    EXPECT_EQ(vv2.asDouble(), 222.22);
+
+    EXPECT_EQ(arr.size(), 3);
+    ASSERT_FALSE(arr.addValue(444.44));
+
+    EXPECT_EQ(arr.size(), 4);
+    auto const cv4 = arr.at(3);
+    ValueView const vv4{cv4};
+    EXPECT_EQ(vv4.asDouble(), 444.44);
+}
+
+TEST(ArrayTest, testArrayPattern)
+{
+    auto const arr = Array{ConfigValue{ConfigType::String}};
+    auto const arrPattern = arr.getArrayPattern();
+    EXPECT_EQ(arrPattern.type(), ConfigType::String);
+}
+
+TEST(ArrayTest, iterateValueArray)
+{
+    auto arr = Array{ConfigValue{ConfigType::Integer}.withConstraint(gValidateUint16)};
+    std::vector<int64_t> const expected{543, 123, 909};
+
+    for (auto const num : expected)
+        ASSERT_FALSE(arr.addValue(num));
+
+    std::vector<int64_t> actual;
+    for (auto it = arr.begin(); it != arr.end(); ++it)
+        actual.emplace_back(std::get<int64_t>(it->getValue()));
+
+    EXPECT_TRUE(std::ranges::equal(expected, actual));
+}
+
+TEST(ArrayTest, addNullOptional)
+{
+    Array arr{ConfigValue{ConfigType::Integer}.optional()};
+    ASSERT_FALSE(arr.addNull());
+    ASSERT_FALSE(arr.addValue(1));
+
+    ASSERT_EQ(arr.size(), 2);
+    EXPECT_FALSE(arr.at(0).hasValue());
+    EXPECT_TRUE(arr.at(1).hasValue());
+    EXPECT_EQ(std::get<int64_t>(arr.at(1).getValue()), 1);
+}
+
+TEST(ArrayTest, addNullDefault)
+{
+    Array arr{ConfigValue{ConfigType::Integer}.defaultValue(42)};
+    ASSERT_FALSE(arr.addNull());
+    ASSERT_FALSE(arr.addValue(1));
+
+    ASSERT_EQ(arr.size(), 2);
+    EXPECT_EQ(std::get<int64_t>(arr.at(0).getValue()), 42);
+    EXPECT_EQ(std::get<int64_t>(arr.at(1).getValue()), 1);
+}
+
+TEST(ArrayTest, addNullRequired)
+{
+    Array arr{ConfigValue{ConfigType::Integer}};
+    auto const error = arr.addNull();
+    EXPECT_TRUE(error.has_value());
+}