Separate unit tests and integration tests (#1393)

Fixes #1391
2025-12-06 17:27:58 +00:00 · 2024-05-07 15:12:48 +01:00
parent 98ef83d470
commit cbc856b190
177 changed files with 168 additions and 106 deletions
--- a/tests/unit/rpc/handlers/DefaultProcessorTests.cpp
+++ b/tests/unit/rpc/handlers/DefaultProcessorTests.cpp
@@ -0,0 +1,87 @@
+//------------------------------------------------------------------------------
+/*
+    This file is part of clio: https://github.com/XRPLF/clio
+    Copyright (c) 2023, the clio developers.
+
+    Permission to use, copy, modify, and distribute this software for any
+    purpose with or without fee is hereby granted, provided that the above
+    copyright notice and this permission notice appear in all copies.
+
+    THE  SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+    WITH  REGARD  TO  THIS  SOFTWARE  INCLUDING  ALL  IMPLIED  WARRANTIES  OF
+    MERCHANTABILITY  AND  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+    ANY  SPECIAL,  DIRECT,  INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+    WHATSOEVER  RESULTING  FROM  LOSS  OF USE, DATA OR PROFITS, WHETHER IN AN
+    ACTION  OF  CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+*/
+//==============================================================================
+
+#include "rpc/FakesAndMocks.hpp"
+#include "rpc/common/Specs.hpp"
+#include "rpc/common/Types.hpp"
+#include "rpc/common/Validators.hpp"
+#include "rpc/common/impl/Processors.hpp"
+#include "util/Fixtures.hpp"
+
+#include <boost/json/parse.hpp>
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+
+using namespace testing;
+using namespace std;
+
+using namespace rpc;
+using namespace rpc::validation;
+using namespace tests::common;
+
+namespace json = boost::json;
+
+class RPCDefaultProcessorTest : public HandlerBaseTest {};
+
+TEST_F(RPCDefaultProcessorTest, ValidInput)
+{
+    runSpawn([](auto yield) {
+        HandlerMock const handler;
+        rpc::impl::DefaultProcessor<HandlerMock> const processor;
+
+        auto const input = json::parse(R"({ "something": "works" })");
+        auto const spec = RpcSpec{{"something", Required{}}};
+        auto const data = InOutFake{"works"};
+        EXPECT_CALL(handler, spec(_)).WillOnce(ReturnRef(spec));
+        EXPECT_CALL(handler, process(Eq(data), _)).WillOnce(Return(data));
+
+        auto const ret = processor(handler, input, Context{yield});
+        ASSERT_TRUE(ret);  // no error
+    });
+}
+
+TEST_F(RPCDefaultProcessorTest, NoInputVaildCall)
+{
+    runSpawn([](auto yield) {
+        HandlerWithoutInputMock const handler;
+        rpc::impl::DefaultProcessor<HandlerWithoutInputMock> const processor;
+
+        auto const data = InOutFake{"works"};
+        auto const input = json::parse(R"({})");
+        EXPECT_CALL(handler, process(_)).WillOnce(Return(data));
+
+        auto const ret = processor(handler, input, Context{yield});
+        ASSERT_TRUE(ret);  // no error
+    });
+}
+
+TEST_F(RPCDefaultProcessorTest, InvalidInput)
+{
+    runSpawn([](auto yield) {
+        HandlerMock const handler;
+        rpc::impl::DefaultProcessor<HandlerMock> const processor;
+
+        auto const input = json::parse(R"({ "other": "nope" })");
+        auto const spec = RpcSpec{{"something", Required{}}};
+        EXPECT_CALL(handler, spec(_)).WillOnce(ReturnRef(spec));
+
+        auto const ret = processor(handler, input, Context{yield});
+        ASSERT_FALSE(ret);  // returns error
+    });
+}