From ca168588785e6c151873197ee6142f39d345ba48 Mon Sep 17 00:00:00 2001
From: cyan317 <120398799+cindyyan317@users.noreply.github.com>
Date: Mon, 13 Nov 2023 13:29:36 +0000
Subject: [PATCH] Add DeliverMax for Tx streams (#980)

---
 src/feed/SubscriptionManager.cpp       | 2 ++
 unittests/SubscriptionManagerTests.cpp | 5 +++++
 2 files changed, 7 insertions(+)

diff --git a/src/feed/SubscriptionManager.cpp b/src/feed/SubscriptionManager.cpp
index 0487c485..7b7fdbb7 100644
--- a/src/feed/SubscriptionManager.cpp
+++ b/src/feed/SubscriptionManager.cpp
@@ -174,6 +174,8 @@ SubscriptionManager::pubTransaction(data::TransactionAndMetadata const& blobs, r
     pubObj["transaction"] = rpc::toJson(*tx);
     pubObj["meta"] = rpc::toJson(*meta);
     rpc::insertDeliveredAmount(pubObj["meta"].as_object(), tx, meta, blobs.date);
+    // hardcode api_version to 1 for now, until https://github.com/XRPLF/clio/issues/978 fixed
+    rpc::insertDeliverMaxAlias(pubObj["transaction"].as_object(), 1);
     pubObj["type"] = "transaction";
     pubObj["validated"] = true;
     pubObj["status"] = "closed";
diff --git a/unittests/SubscriptionManagerTests.cpp b/unittests/SubscriptionManagerTests.cpp
index ea55ae14..8bb1706d 100644
--- a/unittests/SubscriptionManagerTests.cpp
+++ b/unittests/SubscriptionManagerTests.cpp
@@ -397,6 +397,7 @@ TEST_F(SubscriptionManagerSimpleBackendTest, SubscriptionManagerTransaction)
         "transaction":{
             "Account":"rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn",
             "Amount":"1",
+            "DeliverMax":"1",
             "Destination":"rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun",
             "Fee":"1",
             "Sequence":32,
@@ -636,6 +637,7 @@ TEST_F(SubscriptionManagerSimpleBackendTest, SubscriptionManagerAccount)
         "transaction":{
             "Account":"rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn",
             "Amount":"1",
+            "DeliverMax":"1",
             "Destination":"rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun",
             "Fee":"1",
             "Sequence":32,
@@ -695,6 +697,7 @@ TEST_F(SubscriptionManagerSimpleBackendTest, SubscriptionManagerOrderBook)
         "transaction":{
             "Account":"rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn",
             "Amount":"1",
+            "DeliverMax":"1",
             "Destination":"rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun",
             "Fee":"1",
             "Sequence":32,
@@ -752,6 +755,7 @@ TEST_F(SubscriptionManagerSimpleBackendTest, SubscriptionManagerOrderBook)
         "transaction":{
             "Account":"rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn",
             "Amount":"1",
+            "DeliverMax":"1",
             "Destination":"rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun",
             "Fee":"1",
             "Sequence":32,
@@ -795,6 +799,7 @@ TEST_F(SubscriptionManagerSimpleBackendTest, SubscriptionManagerOrderBook)
         "transaction":{
             "Account":"rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn",
             "Amount":"1",
+            "DeliverMax":"1",
             "Destination":"rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun",
             "Fee":"1",
             "Sequence":32,