From bdb72f91a2a8d1d11300f6ce2e7ed0ebbd72f526 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 20 Jun 2024 09:13:24 +0100 Subject: [PATCH] [CI] clang-tidy auto fixes (#1478) Fixes #1477. Please review and commit clang-tidy fixes. Co-authored-by: kuznetsss --- tests/unit/etl/SubscriptionSourceTests.cpp | 2 -- tests/unit/util/requests/RequestBuilderTests.cpp | 1 - tests/unit/util/requests/WsConnectionTests.cpp | 2 -- tests/unit/web/ServerTests.cpp | 16 +++++++--------- 4 files changed, 7 insertions(+), 14 deletions(-) diff --git a/tests/unit/etl/SubscriptionSourceTests.cpp b/tests/unit/etl/SubscriptionSourceTests.cpp index 1752da7f..adc13774 100644 --- a/tests/unit/etl/SubscriptionSourceTests.cpp +++ b/tests/unit/etl/SubscriptionSourceTests.cpp @@ -18,7 +18,6 @@ //============================================================================== #include "etl/impl/SubscriptionSource.hpp" -#include "util/AssignRandomPort.hpp" #include "util/Fixtures.hpp" #include "util/MockNetworkValidatedLedgers.hpp" #include "util/MockSubscriptionManager.hpp" @@ -32,7 +31,6 @@ #include #include -#include #include #include #include diff --git a/tests/unit/util/requests/RequestBuilderTests.cpp b/tests/unit/util/requests/RequestBuilderTests.cpp index 092e5471..19893961 100644 --- a/tests/unit/util/requests/RequestBuilderTests.cpp +++ b/tests/unit/util/requests/RequestBuilderTests.cpp @@ -32,7 +32,6 @@ #include #include -#include #include #include #include diff --git a/tests/unit/util/requests/WsConnectionTests.cpp b/tests/unit/util/requests/WsConnectionTests.cpp index 214b7a53..4b4395ed 100644 --- a/tests/unit/util/requests/WsConnectionTests.cpp +++ b/tests/unit/util/requests/WsConnectionTests.cpp @@ -17,7 +17,6 @@ */ //============================================================================== -#include "util/AssignRandomPort.hpp" #include "util/Fixtures.hpp" #include "util/TestWsServer.hpp" #include "util/requests/Types.hpp" @@ -30,7 +29,6 @@ #include #include -#include #include #include #include diff --git a/tests/unit/web/ServerTests.cpp b/tests/unit/web/ServerTests.cpp index 635d534c..daae6640 100644 --- a/tests/unit/web/ServerTests.cpp +++ b/tests/unit/web/ServerTests.cpp @@ -44,11 +44,9 @@ #include #include -#include #include #include #include -#include #include #include #include @@ -518,7 +516,7 @@ TEST_P(WebServerAdminTest, WsAdminCheck) Config const serverConfig{parse(GetParam().config)}; auto server = makeServerSync(serverConfig, ctx, std::nullopt, dosGuardOverload, e); WebSocketSyncClient wsClient; - uint32_t webServerPort = serverConfig.value("server.port"); + uint32_t const webServerPort = serverConfig.value("server.port"); wsClient.connect("localhost", std::to_string(webServerPort), GetParam().headers); std::string const request = "Why hello"; auto const res = wsClient.syncPost(request); @@ -532,7 +530,7 @@ TEST_P(WebServerAdminTest, HttpAdminCheck) Config const serverConfig{parse(GetParam().config)}; auto server = makeServerSync(serverConfig, ctx, std::nullopt, dosGuardOverload, e); std::string const request = "Why hello"; - uint32_t webServerPort = serverConfig.value("server.port"); + uint32_t const webServerPort = serverConfig.value("server.port"); auto const res = HttpSyncClient::syncPost("localhost", std::to_string(webServerPort), request, GetParam().headers); EXPECT_EQ(res, fmt::format("{} {}", request, GetParam().expectedResponse)); } @@ -607,7 +605,7 @@ INSTANTIATE_TEST_CASE_P( TEST_F(WebServerTest, AdminErrorCfgTestBothAdminPasswordAndLocalAdminSet) { uint32_t webServerPort = tests::util::generateFreePort(); - std::string JSONServerConfigWithBothAdminPasswordAndLocalAdmin = fmt::format( + std::string const JSONServerConfigWithBothAdminPasswordAndLocalAdmin = fmt::format( R"JSON({{ "server":{{ "ip": "0.0.0.0", @@ -627,7 +625,7 @@ TEST_F(WebServerTest, AdminErrorCfgTestBothAdminPasswordAndLocalAdminSet) TEST_F(WebServerTest, AdminErrorCfgTestBothAdminPasswordAndLocalAdminFalse) { uint32_t webServerPort = tests::util::generateFreePort(); - std::string JSONServerConfigWithNoAdminPasswordAndLocalAdminFalse = fmt::format( + std::string const JSONServerConfigWithNoAdminPasswordAndLocalAdminFalse = fmt::format( R"JSON({{ "server": {{ "ip": "0.0.0.0", @@ -648,7 +646,7 @@ struct WebServerPrometheusTest : util::prometheus::WithPrometheus, WebServerTest TEST_F(WebServerPrometheusTest, rejectedWithoutAdminPassword) { auto e = std::make_shared(); - uint32_t webServerPort = tests::util::generateFreePort(); + uint32_t const webServerPort = tests::util::generateFreePort(); Config const serverConfig{parse(JSONServerConfigWithAdminPassword(webServerPort))}; auto server = makeServerSync(serverConfig, ctx, std::nullopt, dosGuard, e); auto const res = HttpSyncClient::syncGet("localhost", std::to_string(webServerPort), "", "/metrics"); @@ -658,7 +656,7 @@ TEST_F(WebServerPrometheusTest, rejectedWithoutAdminPassword) TEST_F(WebServerPrometheusTest, rejectedIfPrometheusIsDisabled) { uint32_t webServerPort = tests::util::generateFreePort(); - std::string JSONServerConfigWithDisabledPrometheus = fmt::format( + std::string const JSONServerConfigWithDisabledPrometheus = fmt::format( R"JSON({{ "server":{{ "ip": "0.0.0.0", @@ -689,7 +687,7 @@ TEST_F(WebServerPrometheusTest, rejectedIfPrometheusIsDisabled) TEST_F(WebServerPrometheusTest, validResponse) { - uint32_t webServerPort = tests::util::generateFreePort(); + uint32_t const webServerPort = tests::util::generateFreePort(); auto& testCounter = PrometheusService::counterInt("test_counter", util::prometheus::Labels()); ++testCounter; auto e = std::make_shared();