ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-06 17:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Fix prometheus tests (#2312)

Browse Source
This commit is contained in:
Sergey Kuznetsov
2025-07-23 15:26:01 +01:00
committed by GitHub
parent 3f0f20a542
commit bcaa5f3392
4 changed files with 24 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/unit/util/prometheus/HttpTests.cpp
View File

@@ -48,15 +48,11 @@ struct PrometheusCheckRequestTestsParams {
bool expected;
};
struct PrometheusCheckRequestTests : public ::testing::TestWithParam<PrometheusCheckRequestTestsParams> {};
struct PrometheusCheckRequestTests : WithPrometheus,
::testing::WithParamInterface<PrometheusCheckRequestTestsParams> {};
TEST_P(PrometheusCheckRequestTests, isPrometheusRequest)
{
ClioConfigDefinition const config{
{"prometheus.enabled", ConfigValue{ConfigType::Boolean}.defaultValue(GetParam().prometheusEnabled)},
{"prometheus.compress_reply", ConfigValue{ConfigType::Boolean}.defaultValue(true)}
};
PrometheusService::init(config);
boost::beast::http::request<boost::beast::http::string_body> req;
req.method(GetParam().method);
req.target(GetParam().target);
@@ -111,9 +107,10 @@ INSTANTIATE_TEST_CASE_P(
tests::util::kNAME_GENERATOR
);
struct PrometheusHandleRequestTests : util::prometheus::WithPrometheus {
struct PrometheusHandleRequestTestsBase {
http::request<http::string_body> const req{http::verb::get, "/metrics", 11};
};
struct PrometheusHandleRequestTests : util::prometheus::WithPrometheus, PrometheusHandleRequestTestsBase {};
TEST_F(PrometheusHandleRequestTests, emptyResponse)
{
@@ -124,13 +121,11 @@ TEST_F(PrometheusHandleRequestTests, emptyResponse)
EXPECT_EQ(response->body(), "");
}
TEST_F(PrometheusHandleRequestTests, prometheusDisabled)
struct PrometheusDisabledHandleRequestTests : util::prometheus::WithPrometheusDisabled,
PrometheusHandleRequestTestsBase {};
TEST_F(PrometheusDisabledHandleRequestTests, prometheusDisabled)
{
ClioConfigDefinition const config{
{"prometheus.enabled", ConfigValue{ConfigType::Boolean}.defaultValue(false)},
{"prometheus.compress_reply", ConfigValue{ConfigType::Boolean}.defaultValue(true)}
};
PrometheusService::init(config);
auto response = handlePrometheusRequest(req, true);
ASSERT_TRUE(response.has_value());
EXPECT_EQ(response->result(), http::status::forbidden);