ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-06 17:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve performance of Counters and add unit-test (#629)

Browse Source 
Fixes #478
This commit is contained in:
Alex Kremer
2023-05-09 14:24:12 +01:00
committed by GitHub
parent 02c0a1f11d
commit b3db4cadab
7 changed files with 94 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/rpc/Counters.cpp
View File

@@ -18,33 +18,17 @@
//==============================================================================
#include <rpc/Counters.h>
#include <rpc/JS.h>
#include <rpc/RPC.h>
#include <rpc/RPCHelpers.h>
namespace RPC {
void
Counters::initializeCounter(std::string const& method)
{
std::shared_lock lk(mutex_);
if (methodInfo_.count(method) == 0)
{
lk.unlock();
std::scoped_lock ulk(mutex_);
// This calls the default constructor for methodInfo of the method.
methodInfo_[method];
}
}
void
Counters::rpcErrored(std::string const& method)
{
initializeCounter(method);
std::shared_lock lk(mutex_);
std::scoped_lock lk(mutex_);
MethodInfo& counters = methodInfo_[method];
counters.started++;
counters.errored++;
}
@@ -52,11 +36,8 @@ Counters::rpcErrored(std::string const& method)
void
Counters::rpcComplete(std::string const& method, std::chrono::microseconds const& rpcDuration)
{
initializeCounter(method);
std::shared_lock lk(mutex_);
std::scoped_lock lk(mutex_);
MethodInfo& counters = methodInfo_[method];
counters.started++;
counters.finished++;
counters.duration += rpcDuration.count();
@@ -65,18 +46,15 @@ Counters::rpcComplete(std::string const& method, std::chrono::microseconds const
void
Counters::rpcForwarded(std::string const& method)
{
initializeCounter(method);
std::shared_lock lk(mutex_);
std::scoped_lock lk(mutex_);
MethodInfo& counters = methodInfo_[method];
counters.forwarded++;
}
boost::json::object
Counters::report() const
{
std::shared_lock lk(mutex_);
std::scoped_lock lk(mutex_);
auto obj = boost::json::object{};
obj[JS(rpc)] = boost::json::object{};