ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-06 17:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Account permission support (#2145)

Browse Source 
Fixes: #1975.
Also switch to libxrpl 2.5.0-b1. Fixes: #2139, #2140.
This commit is contained in:
Sergey Kuznetsov
2025-05-20 13:40:38 +01:00
committed by GitHub
parent 670eaaa51d
commit b3da9adb03
8 changed files with 198 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

131
tests/unit/rpc/handlers/LedgerEntryTests.cpp
View File

@@ -2193,6 +2193,106 @@ generateTestValuesForParametersTest()
.expectedError = "malformedRequest",
.expectedErrorMessage = "Malformed request.",
},
ParamTestCaseBundle{
.testName = "Delegate_InvalidType",
.testJson = R"json({"delegate": 123})json",
.expectedError = "malformedRequest",
.expectedErrorMessage = "Malformed request."
},
ParamTestCaseBundle{
.testName = "Delegate_InvalidStringIndex",
.testJson = R"json({"delegate": "invalid_hex_string"})json",
.expectedError = "malformedRequest",
.expectedErrorMessage = "Malformed request."
},
ParamTestCaseBundle{
.testName = "Delegate_EmptyObject",
.testJson = R"json({"delegate": {}})json",
.expectedError = "malformedRequest",
.expectedErrorMessage = "Malformed request."
},
ParamTestCaseBundle{
.testName = "Delegate_MissingAccount",
.testJson = fmt::format(
R"json({{
"delegate": {{
"authorize": "{}"
}}
}})json",
kACCOUNT2
),
.expectedError = "malformedRequest",
.expectedErrorMessage = "Malformed request."
},
ParamTestCaseBundle{
.testName = "Delegate_AccountNotString",
.testJson = fmt::format(
R"json({{
"delegate": {{
"account": 123,
"authorize": "{}"
}}
}})json",
kACCOUNT2
),
.expectedError = "malformedAddress",
.expectedErrorMessage = "Malformed address."
},
ParamTestCaseBundle{
.testName = "Delegate_AccountInvalid",
.testJson = fmt::format(
R"json({{
"delegate": {{
"account": "invalid_address",
"authorize": "{}"
}}
}})json",
kACCOUNT2
),
.expectedError = "malformedAddress",
.expectedErrorMessage = "Malformed address."
},
ParamTestCaseBundle{
.testName = "Delegate_MissingAuthorize",
.testJson = fmt::format(
R"json({{
"delegate": {{
"account": "{}"
}}
}})json",
kACCOUNT
),
.expectedError = "malformedRequest",
.expectedErrorMessage = "Malformed request."
},
ParamTestCaseBundle{
.testName = "Delegate_AuthorizeNotString",
.testJson = fmt::format(
R"json({{
"delegate": {{
"account": "{}",
"authorize": 123
}}
}})json",
kACCOUNT
),
.expectedError = "malformedAddress",
.expectedErrorMessage = "Malformed address."
},
ParamTestCaseBundle{
.testName = "Delegate_AuthorizeInvalid",
.testJson = fmt::format(
R"json({{
"delegate": {{
"account": "{}",
"authorize": "invalid_address"
}}
}})json",
kACCOUNT
),
.expectedError = "malformedAddress",
.expectedErrorMessage = "Malformed address."
},
};
}
@@ -2957,7 +3057,36 @@ generateTestValuesForNormalPathTest()
ripple::keylet::permissionedDomain(ripple::parseBase58<ripple::AccountID>(kACCOUNT).value(), kRANGE_MAX)
.key,
.mockedEntity = createPermissionedDomainObject(kACCOUNT, kINDEX1, kRANGE_MAX, 0, ripple::uint256{0}, 0)
}
},
NormalPathTestBundle{
.testName = "DelegateViaStringIndex",
.testJson = fmt::format(
R"json({{
"binary": true,
"delegate": "{}"
}})json",
kINDEX1
),
.expectedIndex = ripple::uint256{kINDEX1},
.mockedEntity = createDelegateObject(kACCOUNT, kACCOUNT2, kINDEX1, 0, ripple::uint256{0}, 0)
},
NormalPathTestBundle{
.testName = "DelegateViaObject",
.testJson = fmt::format(
R"json({{
"binary": true,
"delegate": {{
"account": "{}",
"authorize": "{}"
}}
}})json",
kACCOUNT,
kACCOUNT2
),
.expectedIndex =
ripple::keylet::delegate(getAccountIdWithString(kACCOUNT), getAccountIdWithString(kACCOUNT2)).key,
.mockedEntity = createDelegateObject(kACCOUNT, kACCOUNT2, kINDEX1, 0, ripple::uint256{0}, 0)
},
};
}

2
tests/unit/rpc/handlers/TxTests.cpp
View File

@@ -834,7 +834,7 @@ TEST_F(RPCTxTest, CTIDNotMatch)
ASSERT_FALSE(output);
auto const err = rpc::makeError(output.result.error());
EXPECT_EQ(err.at("error").as_string(), "unknown");
EXPECT_EQ(err.at("error").as_string(), "wrongNetwork");
EXPECT_EQ(err.at("error_code").as_uint64(), rpc::RippledError::rpcWRONG_NETWORK);
EXPECT_EQ(
err.at("error_message").as_string(),