Return malformedOwner in ticket.owner for ledger_entry (#344)

Fixes #274
This commit is contained in:
Francis Mendoza
2022-10-26 11:14:02 -07:00
committed by GitHub
parent e56bd7b29e
commit b17ef28f55

View File

@@ -312,10 +312,10 @@ doLedgerEntry(Context const& context)
return Status{Error::rpcINVALID_PARAMS, "malformedTicket"}; return Status{Error::rpcINVALID_PARAMS, "malformedTicket"};
} }
else if ( else if (
!request.at(JS(ticket)).as_object().contains(JS(account)) || !request.at(JS(ticket)).as_object().contains(JS(owner)) ||
!request.at(JS(ticket)).as_object().at(JS(account)).is_string()) !request.at(JS(ticket)).as_object().at(JS(owner)).is_string())
{ {
return Status{Error::rpcINVALID_PARAMS, "malformedTicketAccount"}; return Status{Error::rpcINVALID_PARAMS, "malformedOwner"};
} }
else if ( else if (
!request.at(JS(ticket)).as_object().contains(JS(ticket_seq)) || !request.at(JS(ticket)).as_object().contains(JS(ticket_seq)) ||
@@ -328,13 +328,12 @@ doLedgerEntry(Context const& context)
auto const id = auto const id =
ripple::parseBase58<ripple::AccountID>(request.at(JS(ticket)) ripple::parseBase58<ripple::AccountID>(request.at(JS(ticket))
.as_object() .as_object()
.at(JS(account)) .at(JS(owner))
.as_string() .as_string()
.c_str()); .c_str());
if (!id) if (!id)
return Status{ return Status{Error::rpcINVALID_PARAMS, "malformedOwner"};
Error::rpcINVALID_PARAMS, "malformedTicketAccount"};
else else
{ {
std::uint32_t seq = request.at(JS(offer)) std::uint32_t seq = request.at(JS(offer))