From ade6289de2ca3d12bee37a0ff12e314e369db1ea Mon Sep 17 00:00:00 2001
From: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Date: Thu, 24 Apr 2025 16:48:19 +0100
Subject: [PATCH] refactor: Add str() method to BaseTagDecorator (#2020)

Fix: https://github.com/XRPLF/clio/issues/2008
---
 src/util/Taggable.hpp              | 13 +++++++++++++
 tests/unit/rpc/RPCHelpersTests.cpp |  8 +-------
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/util/Taggable.hpp b/src/util/Taggable.hpp
index 9092c6a1..f2265d94 100644
--- a/src/util/Taggable.hpp
+++ b/src/util/Taggable.hpp
@@ -96,6 +96,19 @@ public:
         decorator.decorate(os);
         return os;
     }
+
+    /**
+     * @brief Gets the string representation of the tag.
+     *
+     * @return The string representation of the tag
+     */
+    std::string
+    toString() const
+    {
+        std::ostringstream oss;
+        decorate(oss);
+        return std::move(oss).str();
+    }
 };
 
 /**
diff --git a/tests/unit/rpc/RPCHelpersTests.cpp b/tests/unit/rpc/RPCHelpersTests.cpp
index 2540e2c0..ffd69898 100644
--- a/tests/unit/rpc/RPCHelpersTests.cpp
+++ b/tests/unit/rpc/RPCHelpersTests.cpp
@@ -1204,19 +1204,13 @@ struct RPCHelpersLogDurationTest : LoggerFixture, testing::WithParamInterface<RP
 TEST_P(RPCHelpersLogDurationTest, LogDuration)
 {
     auto const& tag = taggable.tag();
-    // TOOD: Update in https://github.com/XRPLF/clio/issues/2008
-    auto const tagStr = [&tag]() {
-        std::stringstream ss;
-        ss << tag;
-        return ss.str();
-    }();
 
     logDuration(request, tag, GetParam().duration);
 
     std::string const output = getLoggerString();
 
     EXPECT_NE(output.find(GetParam().expectedLogLevel), std::string::npos) << output;
-    EXPECT_NE(output.find(tagStr), std::string::npos);
+    EXPECT_NE(output.find(tag.toString()), std::string::npos);
 
     if (GetParam().expectDuration) {
         std::string const durationStr = std::to_string(GetParam().duration.count()) + " milliseconds";