ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-09-30 00:48:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Align error messages and rpc-spec 0.1.17 (#3223)

Browse Source
This commit is contained in:
Alex Kremer
2026-09-23 13:29:57 +01:00
committed by GitHub
parent 4a96b6612b
commit ad2ff82ab1
9 changed files with 57 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/rpc/RPCHelpers.cpp
View File

@@ -1538,7 +1538,7 @@ parseBook(
}
if (pays == gets)
return std::unexpected{Status{RippledError::RpcBadMarket, "badMarket"}};
return std::unexpected{Status{RippledError::RpcBadMarket}};
return xrpl::Book{pays, gets, domainID};
}
@@ -1677,7 +1677,7 @@ parseBook(boost::json::object const& request)
}
if (payCurrency == getCurrency && payIssuer == getIssuer)
return std::unexpected{Status{RippledError::RpcBadMarket, "badMarket"}};
return std::unexpected{Status{RippledError::RpcBadMarket}};
std::optional<xrpl::uint256> domainID;
if (request.contains("domain")) {

10
src/rpc/handlers/VaultInfo.cpp
View File

@@ -58,14 +58,8 @@ VaultInfoHandler::VaultInfoHandler(std::shared_ptr<BackendInterface> sharedPtrBa
VaultInfoHandler::Result
VaultInfoHandler::process(VaultInfoHandler::Input const& input, Context const& ctx) const
{
// vault info input must either have owner and sequence, or vault_id only. Wording and code
// match xrpld's VaultInfo.cpp parseVault().
if (not validate(input)) {
return Error{Status{
RippledError::RpcInvalidParams,
"Must specify either 'vault_id' or both 'owner' and 'seq'."
}};
}
if (not validate(input))
return Error{ClioError::RpcMalformedRequest};
auto const range = sharedPtrBackend_->fetchLedgerRange();
ASSERT(range.has_value(), "VaultInfo's ledger range must be available");