diff --git a/.github/actions/build_clio/action.yml b/.github/actions/build_clio/action.yml index 874fdf3d..cc2381a4 100644 --- a/.github/actions/build_clio/action.yml +++ b/.github/actions/build_clio/action.yml @@ -25,5 +25,5 @@ runs: cd build cmake \ --build . \ - --parallel ${{ steps.number_of_threads.outputs.threads_number }} \ + --parallel "${{ steps.number_of_threads.outputs.threads_number }}" \ --target ${{ inputs.targets }} diff --git a/.github/actions/create_issue/action.yml b/.github/actions/create_issue/action.yml index 22db9678..c2dd6628 100644 --- a/.github/actions/create_issue/action.yml +++ b/.github/actions/create_issue/action.yml @@ -36,6 +36,6 @@ runs: --title '${{ inputs.title }}' \ --body-file ./issue.md \ > create_issue.log - created_issue=$(cat create_issue.log | sed 's|.*/||') + created_issue="$(sed 's|.*/||' create_issue.log)" echo "created_issue=$created_issue" >> $GITHUB_OUTPUT rm create_issue.log issue.md diff --git a/.github/actions/generate/action.yml b/.github/actions/generate/action.yml index bab12d3b..59f014ea 100644 --- a/.github/actions/generate/action.yml +++ b/.github/actions/generate/action.yml @@ -60,14 +60,14 @@ runs: install .. \ -of . \ -b $BUILD_OPTION \ - -s build_type=${{ inputs.build_type }} \ + -s build_type="${{ inputs.build_type }}" \ -o clio:static="${STATIC_OPTION}" \ -o clio:tests=True \ -o clio:integration_tests="${INTEGRATION_TESTS_OPTION}" \ -o clio:lint=False \ -o clio:coverage="${CODE_COVERAGE}" \ -o clio:time_trace="${TIME_TRACE}" \ - --profile ${{ inputs.conan_profile }} + --profile "${{ inputs.conan_profile }}" - name: Run cmake shell: bash @@ -83,6 +83,6 @@ runs: cmake \ -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake \ -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" \ - ${SANITIZER_OPTION} \ + "${SANITIZER_OPTION}" \ .. \ -G Ninja diff --git a/.github/actions/get_number_of_threads/action.yml b/.github/actions/get_number_of_threads/action.yml index b425f221..863988af 100644 --- a/.github/actions/get_number_of_threads/action.yml +++ b/.github/actions/get_number_of_threads/action.yml @@ -30,7 +30,7 @@ runs: id: number_of_threads_export shell: bash run: | - num_of_threads=${{ steps.mac_threads.outputs.num || steps.linux_threads.outputs.num }} - shift_by=${{ inputs.subtract_threads }} - shifted=$((num_of_threads - shift_by)) + num_of_threads="${{ steps.mac_threads.outputs.num || steps.linux_threads.outputs.num }}" + shift_by="${{ inputs.subtract_threads }}" + shifted="$((num_of_threads - shift_by))" echo "num=$(( shifted > 1 ? shifted : 1 ))" >> $GITHUB_OUTPUT diff --git a/.github/actions/git_common_ancestor/action.yml b/.github/actions/git_common_ancestor/action.yml index cdc580e5..1e7f16b5 100644 --- a/.github/actions/git_common_ancestor/action.yml +++ b/.github/actions/git_common_ancestor/action.yml @@ -13,4 +13,4 @@ runs: id: find_common_ancestor shell: bash run: | - echo "commit=$(git merge-base --fork-point origin/develop)" >> $GITHUB_OUTPUT + echo "commit=\"$(git merge-base --fork-point origin/develop)\"" >> $GITHUB_OUTPUT diff --git a/.github/actions/prepare_runner/action.yml b/.github/actions/prepare_runner/action.yml index 066082e0..5a202483 100644 --- a/.github/actions/prepare_runner/action.yml +++ b/.github/actions/prepare_runner/action.yml @@ -38,7 +38,7 @@ runs: FORMULA_EXPECTED_SHA256="c7ec95d86f0657638835441871e77541165e0a2581b53b3dd657cf13ad4228d4" mkdir -p /tmp/homebrew-formula - curl -s -L $FORMULA_URL -o /tmp/homebrew-formula/cmake.rb + curl -s -L "$FORMULA_URL" -o /tmp/homebrew-formula/cmake.rb echo "$FORMULA_EXPECTED_SHA256 /tmp/homebrew-formula/cmake.rb" | shasum -a 256 -c @@ -48,7 +48,7 @@ runs: - name: Fix git permissions on Linux if: ${{ runner.os == 'Linux' }} shell: bash - run: git config --global --add safe.directory $PWD + run: git config --global --add safe.directory "$PWD" - name: Set env variables for macOS if: ${{ runner.os == 'macOS' }} @@ -73,5 +73,5 @@ runs: - name: Create directories shell: bash run: | - mkdir -p $CCACHE_DIR - mkdir -p $CONAN_USER_HOME/.conan + mkdir -p "$CCACHE_DIR" + mkdir -p "$CONAN_USER_HOME/.conan" diff --git a/.github/actions/restore_cache/action.yml b/.github/actions/restore_cache/action.yml index f0dcca81..6032e7e8 100644 --- a/.github/actions/restore_cache/action.yml +++ b/.github/actions/restore_cache/action.yml @@ -42,9 +42,9 @@ runs: shell: bash run: | conan info . -j info.json -o clio:tests=True - packages_info=$(cat info.json | jq '.[] | "\(.display_name): \(.id)"' | grep -v 'clio') + packages_info="$(cat info.json | jq '.[] | "\(.display_name): \(.id)"' | grep -v 'clio')" echo "$packages_info" - hash=$(echo "$packages_info" | shasum -a 256 | cut -d ' ' -f 1) + hash="$(echo "$packages_info" | shasum -a 256 | cut -d ' ' -f 1)" rm info.json echo "hash=$hash" >> $GITHUB_OUTPUT diff --git a/.github/actions/setup_conan/action.yml b/.github/actions/setup_conan/action.yml index e2a11ef7..47f34a8f 100644 --- a/.github/actions/setup_conan/action.yml +++ b/.github/actions/setup_conan/action.yml @@ -15,17 +15,17 @@ runs: env: CONAN_PROFILE: ${{ inputs.conan_profile }} run: | - echo "Creating $CONAN_PROFILE conan profile" - conan profile new $CONAN_PROFILE --detect --force - conan profile update settings.compiler.libcxx=libc++ $CONAN_PROFILE - conan profile update settings.compiler.cppstd=20 $CONAN_PROFILE - conan profile update env.CXXFLAGS=-DBOOST_ASIO_DISABLE_CONCEPTS $CONAN_PROFILE - conan profile update "conf.tools.build:cxxflags+=[\"-DBOOST_ASIO_DISABLE_CONCEPTS\"]" $CONAN_PROFILE + echo "Creating \"$CONAN_PROFILE\" conan profile" + conan profile new "$CONAN_PROFILE" --detect --force + conan profile update settings.compiler.libcxx=libc++ "$CONAN_PROFILE" + conan profile update settings.compiler.cppstd=20 "$CONAN_PROFILE" + conan profile update env.CXXFLAGS=-DBOOST_ASIO_DISABLE_CONCEPTS "$CONAN_PROFILE" + conan profile update "conf.tools.build:cxxflags+=[\"-DBOOST_ASIO_DISABLE_CONCEPTS\"]" "$CONAN_PROFILE" - name: Add conan-non-prod artifactory shell: bash run: | - if [[ -z $(conan remote list | grep conan-non-prod) ]]; then + if [[ -z "$(conan remote list | grep conan-non-prod)" ]]; then echo "Adding conan-non-prod" conan remote add --insert 0 conan-non-prod http://18.143.149.228:8081/artifactory/api/conan/conan-non-prod else diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a068075c..278d3d1d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -80,23 +80,23 @@ jobs: shell: bash run: | repoConfigFile=docs/config-description.md - if ! [ -f ${repoConfigFile} ]; then + if ! [ -f "${repoConfigFile}" ]; then echo "Config Description markdown file is missing in docs folder" exit 1 fi chmod +x ./clio_server configDescriptionFile=config_description_new.md - ./clio_server -d ${configDescriptionFile} + ./clio_server -d "${configDescriptionFile}" - configDescriptionHash=$(sha256sum ${configDescriptionFile} | cut -d' ' -f1) - repoConfigHash=$(sha256sum ${repoConfigFile} | cut -d' ' -f1) + configDescriptionHash=$(sha256sum "${configDescriptionFile}" | cut -d' ' -f1) + repoConfigHash=$(sha256sum "${repoConfigFile}" | cut -d' ' -f1) - if [ ${configDescriptionHash} != ${repoConfigHash} ]; then + if [ "${configDescriptionHash}" != "${repoConfigHash}" ]; then echo "Markdown file is not up to date" diff -u "${repoConfigFile}" "${configDescriptionFile}" - rm -f ${configDescriptionFile} + rm -f "${configDescriptionFile}" exit 1 fi - rm -f ${configDescriptionFile} + rm -f "${configDescriptionFile}" exit 0 diff --git a/.github/workflows/build_clio_docker_image.yml b/.github/workflows/build_clio_docker_image.yml index 4e683fc0..d4a86d09 100644 --- a/.github/workflows/build_clio_docker_image.yml +++ b/.github/workflows/build_clio_docker_image.yml @@ -57,7 +57,7 @@ jobs: if: ${{ inputs.clio_server_binary_url != null }} shell: bash run: | - wget ${{inputs.clio_server_binary_url}} -P ./docker/clio/artifact/ + wget "${{inputs.clio_server_binary_url}}" -P ./docker/clio/artifact/ if [ "$(sha256sum ./docker/clio/clio_server | awk '{print $1}')" != "${{inputs.binary_sha256}}" ]; then echo "Binary sha256 sum doesn't match" exit 1 diff --git a/.github/workflows/clang-tidy.yml b/.github/workflows/clang-tidy.yml index df9cf443..df2e2f3f 100644 --- a/.github/workflows/clang-tidy.yml +++ b/.github/workflows/clang-tidy.yml @@ -68,7 +68,7 @@ jobs: shell: bash id: run_clang_tidy run: | - run-clang-tidy-19 -p build -j ${{ steps.number_of_threads.outputs.threads_number }} -fix -quiet 1>output.txt + run-clang-tidy-19 -p build -j "${{ steps.number_of_threads.outputs.threads_number }}" -fix -quiet 1>output.txt - name: Fix local includes if: ${{ steps.run_clang_tidy.outcome != 'success' }} diff --git a/.github/workflows/clang-tidy_on_fix_merged.yml b/.github/workflows/clang-tidy_on_fix_merged.yml index 2b8d2506..fc0b37be 100644 --- a/.github/workflows/clang-tidy_on_fix_merged.yml +++ b/.github/workflows/clang-tidy_on_fix_merged.yml @@ -18,8 +18,8 @@ jobs: id: check shell: bash run: | - passed=$(if [[ $(git log -1 --pretty=format:%s | grep 'style: clang-tidy auto fixes') ]]; then echo 'true' ; else echo 'false' ; fi) - echo "passed=$passed" >> $GITHUB_OUTPUT + passed=$(if [[ "$(git log -1 --pretty=format:%s | grep 'style: clang-tidy auto fixes')" ]]; then echo 'true' ; else echo 'false' ; fi) + echo "passed=\"$passed\"" >> $GITHUB_OUTPUT - name: Run clang-tidy workflow if: ${{ contains(steps.check.outputs.passed, 'true') }}