From 9091bb06f448c9d527ac3d7c4576be1834d92003 Mon Sep 17 00:00:00 2001 From: Alex Kremer Date: Tue, 8 Nov 2022 15:11:41 +0100 Subject: [PATCH] Remove checks for a valid subscription in subscribe/unsubscribe rpc to match rippled (#386) Fixes #348 --- src/rpc/handlers/Subscribe.cpp | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/rpc/handlers/Subscribe.cpp b/src/rpc/handlers/Subscribe.cpp index 7bbe15d0f..af8f8deed 100644 --- a/src/rpc/handlers/Subscribe.cpp +++ b/src/rpc/handlers/Subscribe.cpp @@ -294,12 +294,6 @@ doSubscribe(Context const& context) { auto request = context.params; - if (!request.contains(JS(streams)) && !request.contains(JS(accounts)) && - !request.contains(JS(accounts_proposed)) && - !request.contains(JS(books))) - return Status{ - Error::rpcINVALID_PARAMS, "does not contain valid subscription"}; - if (request.contains(JS(streams))) { if (!request.at(JS(streams)).is_array()) @@ -379,12 +373,6 @@ doUnsubscribe(Context const& context) { auto request = context.params; - if (!request.contains(JS(streams)) && !request.contains(JS(accounts)) && - !request.contains(JS(accounts_proposed)) && - !request.contains(JS(books))) - return Status{ - Error::rpcINVALID_PARAMS, "does not contain valid subscription"}; - if (request.contains(JS(streams))) { if (!request.at(JS(streams)).is_array())