ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-11-28 23:55:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check optional before dereferencing

Browse Source
This commit is contained in:
CJ Cobb
2022-03-04 16:02:20 -05:00
parent b3948590f8
commit 799bf58c95
1 changed files with 19 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/etl/ReportingETL.cpp
View File

@@ -229,8 +229,10 @@ ReportingETL::fetchLedgerData(uint32_t idx)
std::optional<org::xrpl::rpc::v1::GetLedgerResponse> response = std::optional<org::xrpl::rpc::v1::GetLedgerResponse> response =
loadBalancer_->fetchLedger(idx, false, false); loadBalancer_->fetchLedger(idx, false, false);
BOOST_LOG_TRIVIAL(trace) << __func__ << " : " if (response)
<< "GetLedger reply = " << response->DebugString(); BOOST_LOG_TRIVIAL(trace)
<< __func__ << " : "
<< "GetLedger reply = " << response->DebugString();
return response; return response;
} }
@@ -243,8 +245,10 @@ ReportingETL::fetchLedgerDataAndDiff(uint32_t idx)
std::optional<org::xrpl::rpc::v1::GetLedgerResponse> response = std::optional<org::xrpl::rpc::v1::GetLedgerResponse> response =
loadBalancer_->fetchLedger(idx, true, !backend_->cache().isFull()); loadBalancer_->fetchLedger(idx, true, !backend_->cache().isFull());
BOOST_LOG_TRIVIAL(trace) << __func__ << " : " if (response)
<< "GetLedger reply = " << response->DebugString(); BOOST_LOG_TRIVIAL(trace)
<< __func__ << " : "
<< "GetLedger reply = " << response->DebugString();
return response; return response;
} }
@@ -603,17 +607,6 @@ ReportingETL::runETLPipeline(uint32_t startSequence, int numExtractors)
auto time = ((end - start).count()) / 1000000000.0; auto time = ((end - start).count()) / 1000000000.0;
totalTime += time; totalTime += time;
auto tps =
fetchResponse->transactions_list().transactions_size() /
time;
BOOST_LOG_TRIVIAL(info)
<< "Extract phase time = " << time
<< " . Extract phase tps = " << tps
<< " . Avg extract time = "
<< totalTime / (currentSequence - startSequence + 1)
<< " . thread num = " << i
<< " . seq = " << currentSequence;
// if the fetch is unsuccessful, stop. fetchLedger only // if the fetch is unsuccessful, stop. fetchLedger only
// returns false if the server is shutting down, or if the // returns false if the server is shutting down, or if the
// ledger was found in the database (which means another // ledger was found in the database (which means another
@@ -625,6 +618,17 @@ ReportingETL::runETLPipeline(uint32_t startSequence, int numExtractors)
{ {
break; break;
} }
auto tps =
fetchResponse->transactions_list().transactions_size() /
time;
BOOST_LOG_TRIVIAL(info)
<< "Extract phase time = " << time
<< " . Extract phase tps = " << tps
<< " . Avg extract time = "
<< totalTime / (currentSequence - startSequence + 1)
<< " . thread num = " << i
<< " . seq = " << currentSequence;
transformQueue->push(std::move(fetchResponse)); transformQueue->push(std::move(fetchResponse));
currentSequence += numExtractors; currentSequence += numExtractors;